Skip to contentSkip to conversation

staging: dgap: remove unused code

PATCH New Sudip Mukherjee 1 participant 1 message May 9, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: dgap: remove unused code

dgap_sindex() is being only called from dgap_getword() which searches for either ' ' or '\t' or '\n'. this part of the code with '^' at the beginning is never used.

---
 drivers/staging/dgap/dgap.c | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)
drivers/staging/dgap/dgap.c +4 -17
index 6766d5a..6b983bc 100644
@@ -290,8 +290,7 @@ static struct toklist dgap_tlist[] = {
 
 /*
  * dgap_sindex: much like index(), but it looks for a match of any character in
- * the group, and returns that position.  If the first character is a ^, then
- * this will match the first occurrence not in that group.
+ * the group, and returns that position.
  */
 static char *dgap_sindex(char *string, char *group)
 {
@@ -300,23 +299,11 @@ static char *dgap_sindex(char *string, char *group)
 	if (!string || !group)
 		return NULL;
 
-	if (*group == '^') {
-		group++;
-		for (; *string; string++) {
-			for (ptr = group; *ptr; ptr++) {
-				if (*ptr == *string)
-					break;
-			}
-			if (*ptr == '\0')
+	for (; *string; string++) {
+		for (ptr = group; *ptr; ptr++) {
+			if (*ptr == *string)
 				return string;
 		}
-	} else {
-		for (; *string; string++) {
-			for (ptr = group; *ptr; ptr++) {
-				if (*ptr == *string)
-					return string;
-			}
-		}
 	}
 
 	return NULL;
Signature · 1 line
1.8.1.2