Skip to contentSkip to conversation

Patch "serial: of-serial: Remove device_type = "serial" registration" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message May 9, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

serial: of-serial: Remove device_type = "serial" registration

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
serial-of-serial-remove-device_type-serial-registration.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 6befa9d883385c580369a2cc9e53fbf329771f6d Mon Sep 17 00:00:00 2001

From: Michal Simek <[email protected]>
Date: Tue, 14 Apr 2015 12:03:09 +0200
Subject: serial: of-serial: Remove device_type = "serial" registration

From: Michal Simek <[email protected]>

commit 6befa9d883385c580369a2cc9e53fbf329771f6d upstream.

Do not probe all serial drivers by of_serial.c which are using device_type = "serial"; property. Only drivers which have valid compatible strings listed in the driver should be probed.

When PORT_UNKNOWN is setup probe will fail anyway.

Arnd quotation about driver historical background:
"when I wrote that driver initially, the idea was that it would get used as a stub to hook up all other serial drivers but after that, the common code learned to create platform devices from DT"

This patch fix the problem with on the system with xilinx_uartps and 16550a where of_serial failed to register for xilinx_uartps and because of irq_dispose_mapping() removed irq_desc. Then when xilinx_uartps was asking for irq with request_irq() EINVAL is returned.

---
 drivers/tty/serial/of_serial.c |    1 -
 1 file changed, 1 deletion(-)
drivers/tty/serial/of_serial.c +0 -1
@@ -262,7 +262,6 @@ static struct of_device_id of_platform_s
 	{ .compatible = "ibm,qpace-nwp-serial",
 		.data = (void *)PORT_NWPSERIAL, },
 #endif
-	{ .type = "serial",         .data = (void *)PORT_UNKNOWN, },
 	{ /* end of list */ },
 };
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/serial-of-serial-remove-device_type-serial-registration.patch