Skip to contentSkip to conversation

Patch "uas: Set max_sectors_240 quirk for ASM1053 devices" has been added to the 4.0-stable tree

PATCH [email protected] 1 participant 1 message May 9, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

uas: Set max_sectors_240 quirk for ASM1053 devices

to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     uas-set-max_sectors_240-quirk-for-asm1053-devices.patch

and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8e779c6c4a398763c21371fe40f649206041dc1e Mon Sep 17 00:00:00 2001

From: Hans de Goede <[email protected]>
Date: Tue, 21 Apr 2015 11:20:32 +0200
Subject: uas: Set max_sectors_240 quirk for ASM1053 devices

From: Hans de Goede <[email protected]>

commit 8e779c6c4a398763c21371fe40f649206041dc1e upstream.

Testing has shown that ASM1053 devices do not work properly with transfers larger than 240 sectors, so set max_sectors to 240 on these.

---
 drivers/usb/storage/uas-detect.h |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/usb/storage/uas-detect.h +4 -1
@@ -74,7 +74,7 @@ static int uas_use_uas_driver(struct usb
 	 * this writing the following versions exist:
 	 * ASM1051 - no uas support version
 	 * ASM1051 - with broken (*) uas support
-	 * ASM1053 - with working uas support
+	 * ASM1053 - with working uas support, but problems with large xfers
 	 * ASM1153 - with working uas support
 	 *
 	 * Devices with these chips re-use a number of device-ids over the
@@ -104,6 +104,9 @@ static int uas_use_uas_driver(struct usb
 		} else if (usb_ss_max_streams(&eps[1]->ss_ep_comp) == 32) {
 			/* Possibly an ASM1051, disable uas */
 			flags |= US_FL_IGNORE_UAS;
+		} else {
+			/* ASM1053, these have issues with large transfers */
+			flags |= US_FL_MAX_SECTORS_240;
 		}
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.0/uas-set-max_sectors_240-quirk-for-asm1053-devices.patch queue-4.0/uas-allow-uas_use_uas_driver-to-return-usb-storage-flags.patch queue-4.0/uas-add-us_fl_max_sectors_240-flag.patch