Skip to contentSkip to conversation

genirq: devres: Fix testing return value of request_any_context_irq()

PATCH Superseded Axel Lin 1 participant 1 message May 11, 2015 IRQ

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 genirq: devres: Fix testing return value of request_any_context_irq()

request_any_context_irq() returns a negative value on failure. It returns either IRQC_IS_HARDIRQ or IRQC_IS_NESTED on success. So fix testing return value of request_any_context_irq().

Fixes 0668d3065128 ("genirq: Add devm_request_any_context_irq()")
---
 kernel/irq/devres.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/irq/devres.c +1 -1
index d5d0f73..9da7d22 100644
@@ -104,7 +104,7 @@ int devm_request_any_context_irq(struct device *dev, unsigned int irq,
 		return -ENOMEM;
 
 	rc = request_any_context_irq(irq, handler, irqflags, devname, dev_id);
-	if (rc) {
+	if (rc < 0) {
 		devres_free(dr);
 		return rc;
 	}
Signature · 1 line
2.1.0