Skip to contentSkip to conversation

Patch "usb: gadget: printer: enqueue printer's response for setup request" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message May 11, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: gadget: printer: enqueue printer's response for setup request

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-gadget-printer-enqueue-printer-s-response-for-setup-request.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From eb132ccbdec5df46e29c9814adf76075ce83576b Mon Sep 17 00:00:00 2001

From: Andrzej Pietrasiewicz <[email protected]>
Date: Tue, 3 Mar 2015 10:52:05 +0100
Subject: usb: gadget: printer: enqueue printer's response for setup request

From: Andrzej Pietrasiewicz <[email protected]>

commit eb132ccbdec5df46e29c9814adf76075ce83576b upstream.

Function-specific setup requests should be handled in such a way, that apart from filling in the data buffer, the requests are also actually
enqueued: if function-specific setup is called from composte_setup(), the "usb_ep_queue()" block of code in composite_setup() is skipped.

The printer function lacks this part and it results in e.g. get device id requests failing: the host expects some response, the device prepares it but does not equeue it for sending to the host, so the host finally asserts timeout.

This patch adds enqueueing the prepared responses.

Fixes 2e87edf49227: "usb: gadget: make g_printer use composite"
[ported to stable 3.10 and 3.14]
---
 drivers/usb/gadget/printer.c |    9 +++++++++
 1 file changed, 9 insertions(+)
drivers/usb/gadget/printer.c +9 -0
@@ -975,6 +975,15 @@ unknown:
 		break;
 	}
 	/* host either stalls (value < 0) or reports success */
+	if (value >= 0) {
+		req->length = value;
+		req->zero = value < wLength;
+		value = usb_ep_queue(cdev->gadget->ep0, req, GFP_ATOMIC);
+		if (value < 0) {
+			ERROR(dev, "%s:%d Error!\n", __func__, __LINE__);
+			req->status = 0;
+		}
+	}
 	return value;
 }
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/usb-gadget-printer-enqueue-printer-s-response-for-setup-request.patch