Skip to contentSkip to conversation

drivers: staging: rtl8192e: rtllib_softmac.c: auth parse error code byte order fix

PATCH In review Tolga Ceylan 2 participants 2 messages May 13, 2015 – May 31, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: staging: rtl8192e: rtllib_softmac.c: auth parse error code byte order fix

Error code returned from auth_parse() should in cpu byte order. Issue caught by sparse warning: cast from restricted __le16.

---
 drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtllib_softmac.c +1 -1
index 8f5e88b..98afd3b 100644
@@ -1814,7 +1814,7 @@ static inline u16 auth_parse(struct sk_buff *skb, u8 **challenge, int *chlen)
 				return -ENOMEM;
 		}
 	}
-	return cpu_to_le16(a->status);
+	return le16_to_cpu(a->status);
 }
 
 static int auth_rq_parse(struct sk_buff *skb, u8 *dest)
Signature · 1 line
2.4.0
#1 lore raw
Quoted 13 lines · Tolga Ceylan

Error code returned from auth_parse() should in cpu byte order. Issue caught by sparse warning: cast from restricted __le16.

---
 drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtllib_softmac.c +0 -0
index 8f5e88b..98afd3b 100644

drivers/staging/rtl8192e/rtllib_softmac.c static inline u16 auth_parse(struct sk_buff *skb, u8 **challenge, int *chlen) · line 1817

Quoted 5 lines
drivers/staging/rtl8192e/rtllib_softmac.c +1 -1
@@ -1814,7 +1814,7 @@ static inline u16 auth_parse(struct sk_buff *skb, u8 **challenge, int *chlen)
 				return -ENOMEM;
 		}
 	}
-	return cpu_to_le16(a->status);
+	return le16_to_cpu(a->status);

Doesn't apply to my tree :(