Patch "path_openat(): fix double fput()" has been added to the 4.0-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
path_openat(): fix double fput()
to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
path_openat-fix-double-fput.patch
and it can be found in the queue-4.0 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
f15133df088ecadd141ea1907f2c96df67c729f0Mon Sep 17 00:00:00 2001
From: Al Viro <[email protected]>
Date: Fri, 8 May 2015 22:53:15 -0400
Subject: path_openat(): fix double fput()
From: Al Viro <[email protected]>
commit f15133df088ecadd141ea1907f2c96df67c729f0 upstream.
path_openat() jumps to the wrong place after do_tmpfile() - it has already done path_cleanup() (as part of path_lookupat() called by do_tmpfile()), so doing that again can lead to double fput().
--- fs/namei.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/namei.c +2 -1
@@ -3228,7 +3228,7 @@ static struct file *path_openat(int dfd,if (unlikely (file->f_flags & __O_TMPFILE)) { error =do_tmpfile (dfd, pathname, nd, flags, op, file, &opened); - goto out; + goto out2; } error =path_init (dfd, pathname->name, flags, nd);
@@ -3258,6 +3258,7 @@ static struct file *path_openat(int dfd, } out:path_cleanup (nd); +out2:if (!(opened &FILE_OPENED )) {BUG_ON (!error);put_filp (file);
Patches currently in stable-queue which might be from [email protected] are
queue-4.0/path_openat-fix-double-fput.patch