Skip to contentSkip to conversation

drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static

PATCH In review Tolga Ceylan 3 participants 4 messages May 16, 2015 – May 24, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static

visorchipset_file_init() and visorchipset_file_cleanup() functions do not seem to be used from anywhere else and now are declared as static. Sparse emitted "not declared" warnings for these two functions.

---
 drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/unisys/visorbus/visorchipset.c +2 -2
index ca22f49..66ae3d0 100644
@@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = {
 	.mmap = visorchipset_mmap,
 };
 
-int
+static int
 visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
 {
 	int rc = 0;
@@ -2460,7 +2460,7 @@ cleanup:
 	return rc;
 }
 
-void
+static void
 visorchipset_file_cleanup(dev_t major_dev)
 {
 	if (file_cdev.ops)
Signature · 1 line
2.4.0
#1 lore raw
Quoted 25 lines · Tolga Ceylan

visorchipset_file_init() and visorchipset_file_cleanup() functions do not seem to be used from anywhere else and now are declared as static. Sparse emitted "not declared" warnings for these two functions.

---
  drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/unisys/visorbus/visorchipset.c +1 -1
index ca22f49..66ae3d0 100644
@@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = {
  	.mmap = visorchipset_mmap,
  };
 
-int
+static int
  visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
  {
  	int rc = 0;

drivers/staging/unisys/visorbus/visorchipset.c cleanup: · line 2466

Quoted 8 lines
drivers/staging/unisys/visorbus/visorchipset.c +1 -1
@@ -2460,7 +2460,7 @@ cleanup:
  	return rc;
  }
 
-void
+static void
  visorchipset_file_cleanup(dev_t major_dev)
  {
  	if (file_cdev.ops)

I haven't received a response for this patch. Just checking back.

Regards,
Tolga Ceylan

#2 lore raw
Quoted 37 lines · tolga ceylan
Quoted 25 lines · Tolga Ceylan

visorchipset_file_init() and visorchipset_file_cleanup() functions do not seem to be used from anywhere else and now are declared as static. Sparse emitted "not declared" warnings for these two functions.

---
  drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/unisys/visorbus/visorchipset.c +1 -1
index ca22f49..66ae3d0 100644
@@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = {
  	.mmap = visorchipset_mmap,
  };
 
-int
+static int
  visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
  {
  	int rc = 0;

drivers/staging/unisys/visorbus/visorchipset.c cleanup: · line 2466

Quoted 8 lines
drivers/staging/unisys/visorbus/visorchipset.c +1 -1
@@ -2460,7 +2460,7 @@ cleanup:
  	return rc;
  }
 
-void
+static void
  visorchipset_file_cleanup(dev_t major_dev)
  {
  	if (file_cdev.ops)

I haven't received a response for this patch. Just checking back.

Quoted 2 lines

Regards,
Tolga Ceylan

I don't think there is anything wrong with your patch. However, there is a lot of active development going to clean up the code in the unisys tree right now, and your patch conflicts with that. I would prefer to hold off with this for now, until it settles down a bit.

Cheers,
Jes

#3 lore raw
In reply to Tolga Ceylan
Quoted 9 lines · Tolga Ceylan

visorchipset_file_init() and visorchipset_file_cleanup() functions do not seem to be used from anywhere else and now are declared as static. Sparse emitted "not declared" warnings for these two functions.

---
 drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Doesn't apply to my tree :(