tools/kwboot: Add parameters to set delay and timeout via cmdline
PATCH 1/1 tools/kwboot: Add parameters to set delay and timeout via cmdline
To support the Armada 38x, new values for the request-delay and the response-timeout are needed. As the values already implemented in this tool (for Kirkwood and Armada XP) don't seem to work here. To make this more flexible, lets add make those 2 parameters configurable via the cmdline. Here the new parameters:
-q <req-delay>: use specific request-delay
-s <resp-timeo>: use specific response-timeout
For the Marvell DB-88F6820 these values are known to work:
One board:
-q 2 -s 1
2nd board:
-q 5 -s 5
So this seems to be even board specific. But with this patch now those values can be specified and tested via the cmdline.
--- tools/kwboot.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
tools/kwboot.c +12 -2
@@ -657,7 +657,7 @@ static void kwboot_usage(FILE *stream, char *progname) {fprintf (stream, -"Usage: %s [-d | -a | -b <image> | -D <image> ] [ -t ] [-B <baud> ] <TTY>\n" , +"Usage: %s [-d | -a | -q <req-delay> | -s <resp-timeo> | -b <image> | -D <image> ] [ -t ] [-B <baud> ] <TTY>\n" , progname);fprintf (stream,"\n" ); fprintf(stream,
@@ -667,6 +667,8 @@ kwboot_usage(FILE *stream, char *progname) " -D <image>: boot <image> without preamble (Dove)\n");fprintf (stream," -d: enter debug mode\n" );fprintf (stream," -a: use timings for Armada XP\n" ); +fprintf (stream," -q <req-delay>: use specific request-delay\n" ); +fprintf (stream," -s <resp-timeo>: use specific response-timeout\n" );fprintf (stream,"\n" );fprintf (stream," -t: mini terminal\n" );fprintf (stream,"\n" );
@@ -699,7 +701,7 @@ main(int argc, char **argv) kwboot_verbose =isatty (STDOUT_FILENO ); do { - int c = getopt(argc, argv, "hb:ptaB:dD:"); + int c = getopt(argc, argv, "hb:ptaB:dD:q:s:"); if (c < 0) break;
@@ -731,6 +733,14 @@ main(int argc, char **argv) msg_rsp_timeo =KWBOOT_MSG_RSP_TIMEO_AXP ;break ; +case 'q' : + msg_req_delay =atoi (optarg); +break ; + +case 's' : + msg_rsp_timeo =atoi (optarg); +break ; +case 'B' : speed =kwboot_tty_speed (atoi (optarg));if (speed ==-1 )
Signature · 1 line
2.4.2
PATCH 1/1 tools/kwboot: Add parameters to set delay and timeout via cmdline
Hi Stefan,
Quoted 11 lines · Stefan Roese
To support the Armada 38x, new values for the request-delay and the response-timeout are needed. As the values already implemented in this tool (for Kirkwood and Armada XP) don't seem to work here. To make this more flexible, lets add make those 2 parameters configurable via the cmdline. Here the new parameters:
(quoted diff) +0
-2-q <req-delay>: use specific request-delay -s <resp-timeo>: use specific response-timeoutFor the Marvell DB-88F6820 these values are known to work:
Quoted 8 lines
One board:
-q 2 -s 12nd board:
-q 5 -s 5So this seems to be even board specific. But with this patch now those values can be specified and tested via the cmdline.
This seems strange... Anyhow, I have pushed this patch as well as couple of others to marvell/master so it is easier for everybody to test mvebu codebase which is not yet merged in master.
Unless there will be no comments and/or fixups I'll send pull request week after next.
Regards,
Luka