Skip to contentSkip to conversation

netlink and user namespaces

DISCUSSION Alexander Larsson 3 participants 3 messages May 29, 2015 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Now that I'm using a non-privileged user namespace for my desktop sandboxing system all kind of network status things are breaking. The reason for this is that they use netlink to enumerated interfaces, and to verify that the replies are from the kernel (apparently anyone can send anyone netlink messages) this code is verifying that the SCM_CREDENTIAL sender of the netlink messages is uid 0.

For instance:
http://git.0pointer.net/avahi.git/commit/avahi-core/netlink.c?id=37b2be93e63ceff95698f24cd91cb11774eb621c
and:
https://git.gnome.org/browse/glib/tree/gio/gnetworkmonitornetlink.c#n340

This obviously breaks when uid is not mapped (as it can't be in an unprivileged user namespace), as uid will be overflowuid.

Is there any other way to check that a netlink message is from the kernel?

Signature · 6 lines
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       [email protected]            [email protected] 
He's an uncontrollable skateboarding farmboy trapped in a world he never 
made. She's a strong-willed renegade schoolgirl married to the Mob. They 
fight crime! 

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 12 lines · Alexander Larsson

Now that I'm using a non-privileged user namespace for my desktop sandboxing system all kind of network status things are breaking. The reason for this is that they use netlink to enumerated interfaces, and to verify that the replies are from the kernel (apparently anyone can send anyone netlink messages) this code is verifying that the SCM_CREDENTIAL sender of the netlink messages is uid 0.

For instance:
http://git.0pointer.net/avahi.git/commit/avahi-core/netlink.c?id=37b2be93e63ceff95698f24cd91cb11774eb621c
and:
https://git.gnome.org/browse/glib/tree/gio/gnetworkmonitornetlink.c#n340

Quoted 5 lines

This obviously breaks when uid is not mapped (as it can't be in an unprivileged user namespace), as uid will be overflowuid.

Is there any other way to check that a netlink message is from the kernel?

*scratches my head* Those are weird pieces of code.

The answer is the way you do this with any other socket.

Call recvfrom or recvmsg.
Looking at the senders address.
If in the senders address nl_pid == 0 then the message is from the kernel. Otherwise the message is from userspace.

Looking anywhere else at anything else is bogus.

And a note. nl_pid is short for netlink port id. It is not a process id.

Eric

#3 lore raw
In reply to Alexander Larsson
Quoted 12 lines · Alexander Larsson

Now that I'm using a non-privileged user namespace for my desktop sandboxing system all kind of network status things are breaking. The reason for this is that they use netlink to enumerated interfaces, and to verify that the replies are from the kernel (apparently anyone can send anyone netlink messages) this code is verifying that the SCM_CREDENTIAL sender of the netlink messages is uid 0.

For instance:
http://git.0pointer.net/avahi.git/commit/avahi-core/netlink.c?id=37b2be93e63ceff95698f24cd91cb11774eb621c
and:
https://git.gnome.org/browse/glib/tree/gio/gnetworkmonitornetlink.c#n340

Quoted 5 lines

This obviously breaks when uid is not mapped (as it can't be in an unprivileged user namespace), as uid will be overflowuid.

Is there any other way to check that a netlink message is from the kernel?

*scratches my head* Those are weird pieces of code.

The answer is the way you do this with any other socket.

Call recvfrom or recvmsg.
Looking at the senders address.
If in the senders address nl_pid == 0 then the message is from the kernel. Otherwise the message is from userspace.

Looking anywhere else at anything else is bogus.

And a note. nl_pid is short for netlink port id. It is not a process id.

Eric