Skip to contentSkip to conversation

Initial fw_cfg support for qemu-x86 targets.

PATCH New Saket Sinha 1 participant 1 message Dec 28, 2015 14 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): CAK25hWM46Ed8JAOyCqzKFZEsttWD9e_sRQqLdGBXtKiThFb9Mw@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAEUhbmWF1G1VXjtVxoXvKHn1EFb=cRTUM+EKKNNm6yp9U9JB+g@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAK25hWMLiK8KDi+bP3gTbexubzBeC869fQsDjvZ3hSQ1W513rw@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAEUhbmVpNB2R8VXA_9o2ihWim5x+tqxrBWxDGryTgdZXeP+9oQ@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAK25hWO+YJ3u07oHPapPtccm0g8v-kb=yKxVX=yvpWzhvk-qng@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAEUhbmWYgHMhxqC48FQCLGTH4G=ROWkKBeE8WvJ-+DGu9vcyKQ@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAK25hWOC2S9qgt7CBKpkzu_MGoOUMQ4CpHCUXnMgnbG5x3=s8w@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAK25hWN9ycQkacWF8AqR4KqDNNFhnpD2dsPSCJ7Ea0TcJDKmQw@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAEUhbmWEoP=xeXKmo=rSfK0QzsxBzgPTzzHdVCwPWzcScrbdoA@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAK25hWPzfaDA-kcZScPO=OCFETuKEan8YYJJprjWy6dV3OS3RQ@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAEUhbmVNNEbEJ4_fO_rMPJ7WwgBbEnq+p2nhLARm_5vPtM2hEw@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAK25hWPeWN0FhujDoTGwHBcHaf4LjYZVD5=ajpXni4PH_ArrTw@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAEUhbmULaKpZt_caE6+Bg6wux8TPyTq-E01gcHh-fP_993TzXA@mail.gmail.com

#14 lore raw

PATCH 1/1 Initial fw_cfg support for qemu-x86 targets.

Hi Mian,

This was the initial attempt to add fw_cfg interface support for qemu-x86 targets to mainly support ACPI tables.

The patches were dropped due to the issues discussed in the thread.

If we can collaborate the patches in the sense that we are able to load ACPI tables(and other tables) successfully, it would be great.

Regards,
Saket Sinha

---------- Forwarded message ----------
From: Bin Meng <[email protected]>
Date: Fri, Jun 5, 2015 at 2:36 PM
Subject: Re: [PATCH] Initial fw_cfg support for qemu-x86 targets.
To: Saket Sinha <[email protected]>
Cc: Simon Glass <[email protected]>

Hi Saket,

Quoted 14 lines · Saket Sinha

Hi Bin,

Quoted 11 lines
Quoted 5 lines

Error: Hardware did not enter ACPI mode
Unable to enable ACPI
Interpreter disabled.

What can be the reason for these errors ?

Sorry I have no idea. I think you have to read the whole ACPI specification to understand how the ACPI is used to be the interface between OS and the underlying hardware, and that's your primary GSoC job I believe :)

Quoted 6 lines

Sure. I have been going through the ACPI specification. Hope to find how to debug this error soon.

Would it be reasonable to send this patch to mainline now, with the present fw_cfg support that we have got working so far?

I would recommend we investigate the kernel ACPI error first and see what's going on there. Also I noticed that the QEMU fw_cfg ACPI table is huge (exactly 128KB). But lots of its memory space is just zero. I think this needs to be investigated. Also before sending patches to mainline, you need do some house keeping like fixing up all these camel case variables/structure names.

Quoted 8 lines

The next thing I am looking forward to is adding builtin ACPI support for qemu targets in u-boot.

If getting tables from fw_cfg fails, then all these ACPI tables would be written.
Since it would fail for all non-qemu targets, this code snipet would also apply for minnowboard and other x86 targets.

Quoted 6 lines

Something like this -

        fw = fw_cfg_acpi_tables(current);
        if (fw)
                return fw;
        else
                write_acpi_tables(current);

Please follow the same way we write PIRQ/SFI tables. See arch/x86/Kconfig for a Kconfig option control.

Quoted 5 lines

I would deliberatley get it failed for qemu targets to see if builtin ACPI table works.
Once these builtin table start working on qemu, it should work on minnowmax too with little or no changes.

Regards,
Bin