ia64: remove paravirt code
Subsystems (2)
PATCH 1/1 ia64: remove paravirt code
From: "Luis R. Rodriguez" <[email protected]>
All the ia64 pvops code is now dead code since both xen and kvm support have been ripped out [0] [1]. Just that no one had troubled to rip this stuff out. The only useful remaining pieces were the old pvops docs but that was recently also generalized and moved out from ia64 [2].
This has been run time tested on an ia64 Madison system.
[0] 003f7de625890 "KVM: ia64: remove" since v3.19-rc1
[1] d52eefb47d4eb "ia64/xen: Remove Xen support for ia64" since v3.14-rc1
[2] "virtual: Documentation: simplify and generalize paravirt_ops.txt"
---
I've build and run time tested this against linux-next tag next-20150529. The build will fail if you've enabled the LKDTM (Linux Kernel Dump Test Tool Module) enabled on SLE11 ia64 builds, a fix for which I've just posted [3].
[3] https://marc.info/?l=linux-kernel&m=143327018731361&w=2
arch/ia64/Kconfig | 23 - arch/ia64/include/asm/hw_irq.h | 8 - arch/ia64/include/asm/intrinsics.h | 13 - arch/ia64/include/asm/iosapic.h | 4 - arch/ia64/include/asm/module.h | 6 - arch/ia64/include/asm/native/inst.h | 103 +--- arch/ia64/include/asm/native/pvchk_inst.h | 271 --------- arch/ia64/include/asm/paravirt.h | 321 ----------- arch/ia64/include/asm/paravirt_patch.h | 143 ----- arch/ia64/include/asm/paravirt_privop.h | 479 ---------------- arch/ia64/kernel/Makefile | 34 +- arch/ia64/kernel/efi.c | 1 - arch/ia64/kernel/entry.S | 41 +- arch/ia64/kernel/fsys.S | 18 +- arch/ia64/kernel/gate.S | 9 +- arch/ia64/kernel/gate.lds.S | 17 +- arch/ia64/kernel/head.S | 42 -- arch/ia64/kernel/ivt.S | 4 +- arch/ia64/kernel/minstate.h | 2 +- arch/ia64/kernel/module.c | 32 -- arch/ia64/kernel/paravirt.c | 902 ------------------------------ arch/ia64/kernel/paravirt_inst.h | 28 - arch/ia64/kernel/paravirt_patch.c | 514 ----------------- arch/ia64/kernel/paravirt_patchlist.c | 81 --- arch/ia64/kernel/paravirt_patchlist.h | 24 - arch/ia64/kernel/paravirtentry.S | 121 ---- arch/ia64/kernel/patch.c | 38 +- arch/ia64/kernel/setup.c | 12 - arch/ia64/kernel/smpboot.c | 2 - arch/ia64/kernel/time.c | 29 - arch/ia64/kernel/vmlinux.lds.S | 21 - arch/ia64/mm/init.c | 9 +- arch/ia64/scripts/pvcheck.sed | 33 -- 33 files changed, 68 insertions(+), 3317 deletions(-) delete mode 100644 arch/ia64/include/asm/native/pvchk_inst.h delete mode 100644 arch/ia64/include/asm/paravirt.h delete mode 100644 arch/ia64/include/asm/paravirt_patch.h delete mode 100644 arch/ia64/include/asm/paravirt_privop.h delete mode 100644 arch/ia64/kernel/paravirt.c delete mode 100644 arch/ia64/kernel/paravirt_inst.h delete mode 100644 arch/ia64/kernel/paravirt_patch.c delete mode 100644 arch/ia64/kernel/paravirt_patchlist.c delete mode 100644 arch/ia64/kernel/paravirt_patchlist.h delete mode 100644 arch/ia64/kernel/paravirtentry.S delete mode 100644 arch/ia64/scripts/pvcheck.sed
arch/ia64/Kconfig +0 -23
@@ -137,29 +137,6 @@ config AUDIT_ARCH bool default y -menuconfig PARAVIRT_GUEST - bool "Paravirtualized guest support" - depends on BROKEN - help - Say Y here to get to see options related to running Linux under - various hypervisors. This option alone does not add any kernel code. - - If you say N, all options in this submenu will be skipped and disabled. - -if PARAVIRT_GUEST - -config PARAVIRT - bool "Enable paravirtualization code" - depends on PARAVIRT_GUEST - default y - help - This changes the kernel so it can modify itself when it is run - under a hypervisor, potentially improving performance significantly - over full virtualization. However, when run without a hypervisor - the kernel is theoretically slower and slightly larger. - -endif - choice prompt "System type" default IA64_GENERIC
arch/ia64/include/asm/hw_irq.h +0 -8
@@ -15,11 +15,7 @@#include <asm/ptrace.h> #include <asm/smp.h> -#ifndef CONFIG_PARAVIRT typedef u8 ia64_vector ; -#else -typedef u16 ia64_vector ; -#endif /* * 0 special
@@ -114,15 +110,11 @@ DECLARE_PER_CPU(int[IA64_NUM_VECTORS], vector_irq);extern struct irq_chip irq_type_ia64_lsapic;/* CPU-internal interrupt controller */ -#ifdef CONFIG_PARAVIRT_GUEST -#include <asm/paravirt.h> -#else #define ia64_register_ipi ia64_native_register_ipi#define assign_irq_vector ia64_native_assign_irq_vector#define free_irq_vector ia64_native_free_irq_vector#define register_percpu_irq ia64_native_register_percpu_irq#define ia64_resend_irq ia64_native_resend_irq -#endif extern void ia64_native_register_ipi (void );extern int bind_irq_vector (int irq,int vector,cpumask_t domain);
arch/ia64/include/asm/intrinsics.h +0 -13
@@ -7,19 +7,6 @@#ifndef _ASM_IA64_INTRINSICS_H#define _ASM_IA64_INTRINSICS_H -#include <asm/paravirt_privop.h> #include <uapi/asm/intrinsics.h> -#ifndef __ASSEMBLY__ -#if defined(CONFIG_PARAVIRT ) -# undef IA64_INTRINSIC_API -# undef IA64_INTRINSIC_MACRO -# ifdef ASM_SUPPORTED -# define IA64_INTRINSIC_API (name) paravirt_ ## name -# else -# define IA64_INTRINSIC_API (name) pv_cpu_ops.name -# endif -#define IA64_INTRINSIC_MACRO (name) paravirt_ ## name -#endif -#endif /* !__ASSEMBLY__ */ #endif /* _ASM_IA64_INTRINSICS_H */
arch/ia64/include/asm/iosapic.h +0 -4
@@ -55,14 +55,10 @@#define NR_IOSAPICS 256 -#ifdef CONFIG_PARAVIRT_GUEST -#include <asm/paravirt.h> -#else #define iosapic_pcat_compat_init ia64_native_iosapic_pcat_compat_init#define __iosapic_read __ia64_native_iosapic_read#define __iosapic_write __ia64_native_iosapic_write#define iosapic_get_irq_chip ia64_native_iosapic_get_irq_chip -#endif extern void __init ia64_native_iosapic_pcat_compat_init (void );extern struct irq_chip *ia64_native_iosapic_get_irq_chip (unsigned long trigger);
arch/ia64/include/asm/module.h +0 -6
@@ -18,12 +18,6 @@ struct mod_arch_specific {struct elf64_shdr *got;/* global offset table */ struct elf64_shdr *opd;/* official procedure descriptors */ struct elf64_shdr *unwind;/* unwind-table section */ -#ifdef CONFIG_PARAVIRT -struct elf64_shdr *paravirt_bundles; -/* paravirt_alt_bundle_patch table */ -struct elf64_shdr *paravirt_insts; -/* paravirt_alt_inst_patch table */ -#endif unsigned long gp;/* global-pointer for module */ void *core_unw_table;/* core unwind-table cookie returned by unwinder */
arch/ia64/include/asm/native/inst.h +21 -82
174 lines not on this page · raw message
arch/ia64/include/asm/native/pvchk_inst.h deleted +0 -271
271 lines not on this page · raw message
arch/ia64/include/asm/paravirt.h deleted +0 -321
321 lines not on this page · raw message
arch/ia64/include/asm/paravirt_patch.h deleted +0 -143
143 lines not on this page · raw message
arch/ia64/include/asm/paravirt_privop.h deleted +0 -479
479 lines not on this page · raw message
arch/ia64/kernel/Makefile +1 -33
@@ -9,7 +9,7 @@ endif extra-y := head.o init_task.o vmlinux.lds obj-y := entry.o efi.o efi_stub.o gate-data.o fsys.o ia64_ksyms.o irq.o irq_ia64.o \ - irq_lsapic.o ivt.o machvec.o pal.o paravirt_patchlist.o patch.o process.o perfmon.o ptrace.o sal.o \ + irq_lsapic.o ivt.o machvec.o pal.o patch.o process.o perfmon.o ptrace.o sal.o \ salinfo.o setup.o signal.o sys_ia64.o time.o traps.o unaligned.o \ unwind.o mca.o mca_asm.o topology.o dma-mapping.o
@@ -35,9 +35,6 @@ mca_recovery-y += mca_drv.o mca_drv_asm.o obj-$(CONFIG_IA64_MC_ERR_INJECT)+= err_inject.o obj-$(CONFIG_STACKTRACE) += stacktrace.o -obj-$(CONFIG_PARAVIRT) += paravirt.o paravirtentry.o \ - paravirt_patch.o - obj-$(CONFIG_IA64_ESI) += esi.o ifneq ($(CONFIG_IA64_ESI),) obj-y += esi_stub.o # must be in kernel proper
@@ -52,8 +49,6 @@ CFLAGS_traps.o += -mfixed-range=f2-f5,f16-f31 # The gate DSO image is built using a special linker script. include $(src)/Makefile.gate -# tell compiled for native -CPPFLAGS_gate.lds += -D__IA64_GATE_PARAVIRTUALIZED_NATIVE # Calculate NR_IRQ = max(IA64_NATIVE_NR_IRQS, XEN_NR_IRQS, ...) based on config define sed-y
@@ -84,30 +79,3 @@ arch/$(SRCARCH)/kernel/nr-irqs.s: arch/$(SRCARCH)/kernel/nr-irqs.c include/generated/nr-irqs.h: arch/$(SRCARCH)/kernel/nr-irqs.s $(Q)mkdir -p $(dir $@) $(call cmd,nr_irqs) - -# -# native ivt.S, entry.S and fsys.S -# -ASM_PARAVIRT_OBJS = ivt.o entry.o fsys.o -define paravirtualized_native -AFLAGS_$(1) += -D__IA64_ASM_PARAVIRTUALIZED_NATIVE -AFLAGS_pvchk-sed-$(1) += -D__IA64_ASM_PARAVIRTUALIZED_PVCHECK -extra-y += pvchk-$(1) -endef -$(foreach obj,$(ASM_PARAVIRT_OBJS),$(eval $(call paravirtualized_native,$(obj)))) - -# -# Checker for paravirtualizations of privileged operations. -# -quiet_cmd_pv_check_sed = PVCHK $@ -define cmd_pv_check_sed - sed -f $(srctree)/arch/$(SRCARCH)/scripts/pvcheck.sed $< > $@ -endef - -$(obj)/pvchk-sed-%.s: $(src)/%.S $(srctree)/arch/$(SRCARCH)/scripts/pvcheck.sed FORCE - $(call if_changed_dep,as_s_S) -$(obj)/pvchk-%.s: $(obj)/pvchk-sed-%.s FORCE - $(call if_changed,pv_check_sed) -$(obj)/pvchk-%.o: $(obj)/pvchk-%.s FORCE - $(call if_changed,as_o_S) -.PRECIOUS: $(obj)/pvchk-sed-%.s $(obj)/pvchk-%.s $(obj)/pvchk-%.o
arch/ia64/kernel/efi.c +0 -1
@@ -464,7 +464,6 @@ efi_map_pal_code (void)GRANULEROUNDDOWN ((unsigned long ) pal_vaddr),pte_val (pfn_pte (__pa (pal_vaddr) >>PAGE_SHIFT ,PAGE_KERNEL )), IA64_GRANULE_SHIFT); -paravirt_dv_serialize_data ();ia64_set_psr (psr);/* restore psr */ }
arch/ia64/kernel/entry.S +14 -27
121 lines not on this page · raw message
arch/ia64/kernel/fsys.S +9 -9
@@ -24,7 +24,7 @@ #include <asm/unistd.h> #include "entry.h" -#include "paravirt_inst.h" +#include <asm/native/inst.h> /* * See Documentation/ia64/fsys.txt for details on fsyscalls.
@@ -402,7 +402,7 @@ ENTRY(fsys_fallback_syscall) mov r26=ar.pfs END(fsys_fallback_syscall) /* FALL THROUGH */ -GLOBAL_ENTRY(paravirt_fsys_bubble_down) +GLOBAL_ENTRY(fsys_bubble_down) .prologue .altrp b6 .body
@@ -440,7 +440,7 @@ GLOBAL_ENTRY(paravirt_fsys_bubble_down) * * PSR.BE : already is turned off in __kernel_syscall_via_epc() * PSR.AC : don't care (kernel normally turns PSR.AC on) - * PSR.I : already turned off by the time paravirt_fsys_bubble_down gets + * PSR.I : already turned off by the time fsys_bubble_down gets * invoked * PSR.DFL: always 0 (kernel never turns it on) * PSR.DFH: don't care --- kernel never touches f32-f127 on its own
@@ -450,7 +450,7 @@ GLOBAL_ENTRY(paravirt_fsys_bubble_down) * PSR.DB : don't care --- kernel never enables kernel-level * breakpoints * PSR.TB : must be 0 already; if it wasn't zero on entry to - * __kernel_syscall_via_epc, the branch to paravirt_fsys_bubble_down + * __kernel_syscall_via_epc, the branch to fsys_bubble_down * will trigger a taken branch; the taken-trap-handler then * converts the syscall into a break-based system-call. */
@@ -541,14 +541,14 @@ GLOBAL_ENTRY(paravirt_fsys_bubble_down) nop.m 0 (p8) br.call.sptk.many b6=b6 // B (ignore return address) br.cond.spnt ia64_trace_syscall // B -END(paravirt_fsys_bubble_down) +END(fsys_bubble_down) .rodata .align 8 - .globl paravirt_fsyscall_table + .globl fsyscall_table - data8 paravirt_fsys_bubble_down -paravirt_fsyscall_table: + data8 fsys_bubble_down +fsyscall_table: data8 fsys_ni_syscall data8 0 // exit // 1025 data8 0 // read
@@ -833,4 +833,4 @@ paravirt_fsyscall_table: // fill in zeros for the remaining entries .zero: - .space paravirt_fsyscall_table + 8*NR_syscalls - .zero, 0 + .space fsyscall_table + 8*NR_syscalls - .zero, 0
arch/ia64/kernel/gate.S +1 -8
@@ -14,7 +14,7 @@ #include <asm/unistd.h> #include <asm/kregs.h> #include <asm/page.h> -#include "paravirt_inst.h" +#include <asm/native/inst.h> /* * We can't easily refer to symbols inside the kernel. To avoid full runtime relocation,
@@ -376,11 +376,4 @@ GLOBAL_ENTRY(__kernel_syscall_via_epc) (p9) mov r8=ENOSYS FSYS_RETURN -#ifdef CONFIG_PARAVIRT - /* - * padd to make the size of this symbol constant - * independent of paravirtualization. - */ - .align PAGE_SIZE / 8 -#endif END(__kernel_syscall_via_epc)
arch/ia64/kernel/gate.lds.S +8 -9
@@ -6,7 +6,6 @@ */ #include <asm/page.h> -#include "paravirt_patchlist.h" SECTIONS {
@@ -33,21 +32,21 @@ SECTIONS . = GATE_ADDR + 0x600; .data..patch : { - __paravirt_start_gate_mckinley_e9_patchlist = .; + __start_gate_mckinley_e9_patchlist = .; *(.data..patch.mckinley_e9) - __paravirt_end_gate_mckinley_e9_patchlist = .; + __end_gate_mckinley_e9_patchlist = .; - __paravirt_start_gate_vtop_patchlist = .; + __start_gate_vtop_patchlist = .; *(.data..patch.vtop) - __paravirt_end_gate_vtop_patchlist = .; + __end_gate_vtop_patchlist = .; - __paravirt_start_gate_fsyscall_patchlist = .; + __start_gate_fsyscall_patchlist = .; *(.data..patch.fsyscall_table) - __paravirt_end_gate_fsyscall_patchlist = .; + __end_gate_fsyscall_patchlist = .; - __paravirt_start_gate_brl_fsys_bubble_down_patchlist = .; + __start_gate_brl_fsys_bubble_down_patchlist = .; *(.data..patch.brl_fsys_bubble_down) - __paravirt_end_gate_brl_fsys_bubble_down_patchlist = .; + __end_gate_brl_fsys_bubble_down_patchlist = .; } :readable .IA_64.unwind_info : { *(.IA_64.unwind_info*) }
arch/ia64/kernel/head.S +0 -42
60 lines not on this page · raw message
arch/ia64/kernel/ivt.S +1 -3
@@ -937,7 +937,6 @@ END(interrupt) * - ar.fpsr: set to kernel settings * - b6: preserved (same as on entry) */ -#ifdef __IA64_ASM_PARAVIRTUALIZED_NATIVE GLOBAL_ENTRY(ia64_syscall_setup) #if PT(B6) != 0 # error This code assumes that b6 is the first field in pt_regs.
@@ -1029,7 +1028,6 @@ GLOBAL_ENTRY(ia64_syscall_setup) (p10) mov r8=-EINVAL br.ret.sptk.many b7 END(ia64_syscall_setup) -#endif /* __IA64_ASM_PARAVIRTUALIZED_NATIVE */ .org ia64_ivt+0x3c00 /////////////////////////////////////////////////////////////////////////////////////////
@@ -1043,7 +1041,7 @@ END(ia64_syscall_setup) DBG_FAULT(16) FAULT(16) -#if defined(CONFIG_VIRT_CPU_ACCOUNTING_NATIVE) && defined(__IA64_ASM_PARAVIRTUALIZED_NATIVE) +#if defined(CONFIG_VIRT_CPU_ACCOUNTING_NATIVE) /* * There is no particular reason for this code to be here, other than * that there happens to be space here that would go unused otherwise.
arch/ia64/kernel/minstate.h +1 -1
@@ -2,7 +2,7 @@#include <asm/cache.h> #include "entry.h" -#include "paravirt_inst.h" +#include <asm/native/inst.h> #ifdef CONFIG_VIRT_CPU_ACCOUNTING_NATIVE /* read ar.itc in advance, and use it before leaving bank 0 */
arch/ia64/kernel/module.c +0 -32
@@ -439,14 +439,6 @@ module_frob_arch_sections (Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, char *secstrings, mod->arch.opd = s; else if (strcmp(".IA_64.unwind", secstrings + s->sh_name) == 0) mod->arch.unwind = s; -#ifdef CONFIG_PARAVIRT - else if (strcmp(".paravirt_bundles", - secstrings + s->sh_name) == 0) - mod->arch.paravirt_bundles = s; - else if (strcmp(".paravirt_insts", - secstrings + s->sh_name) == 0) - mod->arch.paravirt_insts = s; -#endif if (!mod->arch.core_plt || !mod->arch.init_plt || !mod->arch.got || !mod->arch.opd) {printk (KERN_ERR "%s: sections missing\n" , mod->name);
@@ -914,30 +906,6 @@ module_finalize (const Elf_Ehdr *hdr, const Elf_Shdr *sechdrs, struct module *moDEBUGP ("%s: init: entry=%p\n" , __func__, mod->init);if (mod->arch.unwind)register_unwind_table (mod); -#ifdef CONFIG_PARAVIRT -if (mod->arch.paravirt_bundles) { -struct paravirt_patch_site_bundle *start = - (struct paravirt_patch_site_bundle *) - mod->arch.paravirt_bundles->sh_addr; -struct paravirt_patch_site_bundle *end = - (struct paravirt_patch_site_bundle *) - (mod->arch.paravirt_bundles->sh_addr + - mod->arch.paravirt_bundles->sh_size); - -paravirt_patch_apply_bundle (start, end); - } -if (mod->arch.paravirt_insts) { -struct paravirt_patch_site_inst *start = - (struct paravirt_patch_site_inst *) - mod->arch.paravirt_insts->sh_addr; -struct paravirt_patch_site_inst *end = - (struct paravirt_patch_site_inst *) - (mod->arch.paravirt_insts->sh_addr + - mod->arch.paravirt_insts->sh_size); - -paravirt_patch_apply_inst (start, end); - } -#endif return 0 ; }
arch/ia64/kernel/paravirt.c deleted +0 -902
902 lines not on this page · raw message
arch/ia64/kernel/paravirt_inst.h deleted +0 -28
@@ -1,28 +0,0 @@ -/****************************************************************************** -* linux/arch/ia64/xen/paravirt_inst.h -* -* Copyright (c) 2008 Isaku Yamahata <yamahata at valinux co jp> -* VA Linux Systems Japan K.K. -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2 of the License, or -* (at your option) any later version. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -* -*/ - -#ifdef __IA64_ASM_PARAVIRTUALIZED_PVCHECK -#include <asm/native/pvchk_inst.h> -#else -#include <asm/native/inst.h> -#endif -
arch/ia64/kernel/paravirt_patch.c deleted +0 -514
155 lines not on this page · raw message
arch/ia64/kernel/paravirt_patchlist.c deleted +0 -81
81 lines not on this page · raw message
arch/ia64/kernel/paravirt_patchlist.h deleted +0 -24
Lines of this file are not shown. View the raw message.
arch/ia64/kernel/paravirtentry.S deleted +0 -121
121 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.3.2.209.gd67f9d5.dirty
Part of the diff is not shown here. View the raw message.
Quoted 14 lines · Luis R. Rodriguez
From: "Luis R. Rodriguez" <[email protected]>
All the ia64 pvops code is now dead code since both xen and kvm support have been ripped out [0] [1]. Just that no one had troubled to rip this stuff out. The only useful remaining pieces were the old pvops docs but that was recently also generalized and moved out from ia64 [2].
This has been run time tested on an ia64 Madison system.
[0]
003f7de625890"KVM: ia64: remove" since v3.19-rc1
[1]d52eefb47d4eb"ia64/xen: Remove Xen support for ia64" since v3.14-rc1
[2] "virtual: Documentation: simplify and generalize paravirt_ops.txt"
Quoted 8 lines
Signed-off-by Luis R. Rodriguez <[email protected]>---
I've build and run time tested this against linux-next tag next-20150529. The build will fail if you've enabled the LKDTM (Linux Kernel Dump Test Tool Module) enabled on SLE11 ia64 builds, a fix for which I've just posted [3].
Hey folks, any feedback?
Luis
PiBIZXkgZm9sa3MsIGFueSBmZWVkYmFjaz8NCg0KU29ycnkgLSBpdCBzb3VuZHMgbGlrZSBhIGdv b2QgaWRlYSAtIGhhdmVuJ3QgaGFkIHRpbWUgdG8gcGxheSB3aXRoIHRoZSBwYXRjaCB5ZXQuDQoN Ci1Ub255DQo
Quoted 14 lines · Luis R. Rodriguez
From: "Luis R. Rodriguez" <[email protected]>
All the ia64 pvops code is now dead code since both xen and kvm support have been ripped out [0] [1]. Just that no one had troubled to rip this stuff out. The only useful remaining pieces were the old pvops docs but that was recently also generalized and moved out from ia64 [2].
This has been run time tested on an ia64 Madison system.
[0]
003f7de625890"KVM: ia64: remove" since v3.19-rc1
[1]d52eefb47d4eb"ia64/xen: Remove Xen support for ia64" since v3.14-rc1
[2] "virtual: Documentation: simplify and generalize paravirt_ops.txt"
Quoted 8 lines
Signed-off-by Luis R. Rodriguez <[email protected]>---
I've build and run time tested this against linux-next tag next-20150529. The build will fail if you've enabled the LKDTM (Linux Kernel Dump Test Tool Module) enabled on SLE11 ia64 builds, a fix for which I've just posted [3].
So this builds cleanly on all my test configurations, and boots on the one machine that I tried it on - good job.
But I'm wondering how much of this was auto-generated (and so perhaps free from typos) and how much was done by hand?
It isn't a full revert of the patch series that added paravirt ... you simplified macros like:
#define MOV_TO_KR(kr, reg, clob0, clob1) \ - mov IA64_KR(kr) = reg \ - CLOBBER(clob0) \
- CLOBBER(clob1)
+ mov IA64_KR(kr) = reg
but didn't remove them completely.
So what can I do to validate this 4000+ line patch? Can I compare disassembled ".o" files pre/post patch somehow to be sure this doesn't have some small typo errors somewhere?
-Tony
Quoted 23 lines · Tony Luck
Quoted 21 lines · Luis R. Rodriguez
From: "Luis R. Rodriguez" <[email protected]>
All the ia64 pvops code is now dead code since both xen and kvm support have been ripped out [0] [1]. Just that no one had troubled to rip this stuff out. The only useful remaining pieces were the old pvops docs but that was recently also generalized and moved out from ia64 [2].
This has been run time tested on an ia64 Madison system.
[0]
003f7de625890"KVM: ia64: remove" since v3.19-rc1
[1]d52eefb47d4eb"ia64/xen: Remove Xen support for ia64" since v3.14-rc1
[2] "virtual: Documentation: simplify and generalize paravirt_ops.txt"Signed-off-by Luis R. Rodriguez <[email protected]>---
I've build and run time tested this against linux-next tag next-20150529. The build will fail if you've enabled the LKDTM (Linux Kernel Dump Test Tool Module) enabled on SLE11 ia64 builds, a fix for which I've just posted [3].
Quoted 5 lines
Quoted 1 line
So this builds cleanly on all my test configurations, and boots on the one machine that I tried it on - good job.
Thanks!
Quoted 2 lines
But I'm wondering how much of this was auto-generated (and so perhaps free from typos) and how much was done by hand?
I did this work to help study alternatives to how pvops was implemented on other architectures, so I studied the patches that introduced the code meticulously and then used my editor / editor regexps to make substitutions as needed and shift code as needed. Compile testing found some minor typos, which were easy to fix.
Quoted 9 lines
It isn't a full revert of the patch series that added paravirt ... you simplified macros like:
#defineMOV_TO_KR(kr, reg, clob0, clob1)\arch/ia64/include/asm/native/inst.h +1
-3- mov IA64_KR(kr) = reg \ -CLOBBER (clob0) \ -CLOBBER (clob1) +mov IA64_KR (kr ) = regbut didn't remove them completely.
Right, this IMHO was not necessary at this point but I can understand if you want that. I think that could be done as a separate patch too though and perhaps done through a machine, not human and manually.
Quoted 3 lines
So what can I do to validate this 4000+ line patch? Can I compare disassembled ".o" files pre/post patch somehow to be sure this doesn't have some small typo errors somewhere?
Its quite a huge chunk of code removed, I doubt that .o files would remain intact after this, but I could be wrong. I think run time validation and examination of the code changes, understanding of the code changes is necessary, but also likely just as run time tests.
Is there no ia64 regression test suite?
I don't see ia64 getting much love anyway these days so would it not hurt to merge and spin through linux-next for a while and if no issues are reported make it fly in?
Luis
Quoted 4 lines · Luis R. Rodriguez
Its quite a huge chunk of code removed, I doubt that .o files would remain intact after this, but I could be wrong. I think run time validation and examination of the code changes, understanding of the code changes is necessary, but also likely just as run time tests.
Actually it seems the most of the .o files below arch/ia64/kernel look quite similar ... some post-processing of the "objdump -d" output the squash out addreses ... and the before/after .o files have few enough differences that they can be looked at manually.
Quoted 1 line
Is there no ia64 regression test suite?
Not really.
Quoted 3 lines
I don't see ia64 getting much love anyway these days so would it not hurt to merge and spin through linux-next for a while and if no issues are reported make it fly in?
Not sure how many people besides me are booting linux-next kernels.
Still - let's give it a try,
-Tony