Skip to contentSkip to conversation

Patch "hwmon: (nct6775) Add missing sysfs attribute initialization" has been added to the 4.0-stable tree

PATCH [email protected] 1 participant 1 message Jun 3, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

hwmon: (nct6775) Add missing sysfs attribute initialization

to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
hwmon-nct6775-add-missing-sysfs-attribute-initialization.patch
and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 1b63bf617206ff35b93c57c67bbe067ac735a85a Mon Sep 17 00:00:00 2001

From: Guenter Roeck <[email protected]>
Date: Thu, 28 May 2015 09:08:09 -0700
Subject: hwmon: (nct6775) Add missing sysfs attribute initialization

From: Guenter Roeck <[email protected]>

commit 1b63bf617206ff35b93c57c67bbe067ac735a85a upstream.

The following error message is seen when loading the nct6775 driver with DEBUG_LOCK_ALLOC enabled.

BUG: key ffff88040b2f0030 not in .data!
------------[ cut here ]------------
WARNING: CPU: 0 PID: 186 at kernel/locking/lockdep.c:2988
				lockdep_init_map+0x469/0x630()

DEBUG_LOCKS_WARN_ON(1)

Caused by a missing call to sysfs_attr_init() when initializing sysfs attributes.

---
 drivers/hwmon/nct6775.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/hwmon/nct6775.c +2 -0
@@ -994,6 +994,7 @@ nct6775_create_attr_group(struct device
 				 (*t)->dev_attr.attr.name, tg->base + i);
 			if ((*t)->s2) {
 				a2 = &su->u.a2;
+				sysfs_attr_init(&a2->dev_attr.attr);
 				a2->dev_attr.attr.name = su->name;
 				a2->nr = (*t)->u.s.nr + i;
 				a2->index = (*t)->u.s.index;
@@ -1004,6 +1005,7 @@ nct6775_create_attr_group(struct device
 				*attrs = &a2->dev_attr.attr;
 			} else {
 				a = &su->u.a1;
+				sysfs_attr_init(&a->dev_attr.attr);
 				a->dev_attr.attr.name = su->name;
 				a->index = (*t)->u.index + i;
 				a->dev_attr.attr.mode =

Patches currently in stable-queue which might be from [email protected] are

queue-4.0/hwmon-ntc_thermistor-ensure-iio-channel-is-of-type-iio_voltage.patch queue-4.0/hwmon-tmp401-do-not-auto-detect-chip-on-i2c-address-0x37.patch queue-4.0/hwmon-nct6775-add-missing-sysfs-attribute-initialization.patch queue-4.0/hwmon-nct6683-add-missing-sysfs-attribute-initialization.patch