Skip to contentSkip to conversation

vTPM: set virtual device before passing to ibmvtpm_reset_crq]

PATCH New Hon Ching (Vicky) Lo 1 participant 1 message Jun 4, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vTPM: set virtual device before passing to ibmvtpm_reset_crq]

Hi Peter,

Would it be possible for you to review and commit the following patch at your earliest convenience? Thanks in advance!

-------- Forwarded Message --------
From: Ashley Lai <[email protected]>
To: Hon Ching(Vicky) Lo <[email protected]>
Cc: [email protected], Peter Huewe <[email protected]>, Ashley Lai <[email protected]>, Vicky Lo <[email protected]>, [email protected], Joy Latten <[email protected]>
Subject: Re: [PATCH] vTPM: set virtual device before passing to ibmvtpm_reset_crq
Date: Tue, 2 Jun 2015 00:50:43 -0500 (CDT)

Thanks for the patch. Looks good to me.

--Ashley Lai

Quoted 37 lines · Hon Ching(Vicky) Lo

tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq, the phype call contains empty unit addresses, ibmvtpm->vdev->unit_address.

---
drivers/char/tpm/tpm_ibmvtpm.c | 5 +++--

1 files changed, 3 insertions(+), 2 deletions(-)
drivers/char/tpm/tpm_ibmvtpm.c +3 -2
index 42ffa5e..27ebf95 100644
@@ -578,6 +578,9 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
 		goto cleanup;
 	}
 
+	ibmvtpm->dev = dev;
+	ibmvtpm->vdev = vio_dev;
+
 	crq_q = &ibmvtpm->crq_queue;
 	crq_q->crq_addr = (struct ibmvtpm_crq *)get_zeroed_page(GFP_KERNEL);
 	if (!crq_q->crq_addr) {
@@ -622,8 +625,6 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
 
 	crq_q->index = 0;
 
-	ibmvtpm->dev = dev;
-	ibmvtpm->vdev = vio_dev;
 	TPM_VPRIV(chip) = (void *)ibmvtpm;
 
 	spin_lock_init(&ibmvtpm->rtce_lock);
Signature · 1 line
1.7.1

Best Regards,
Vicky