Skip to contentSkip to conversation

hfsplus: release bnode pages after use, not before

PATCH Sergei Antonov 1 participant 1 message Jun 8, 2015 1 message not in the archive VFS

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 20 lines · Hin-Tak Leung

------------------------------

Quoted 6 lines · BST Vyacheslav Dubeyko

On Sun, 2015-06-07 at 02:42 +0200, Sergei Antonov wrote:
Fix this bugreport by Sasha Levin:
http://lkml.org/lkml/2015/2/20/85 ("use after free")
Make sure mapped pages are available for the entire lifetime of hfs_bnode.

Quoted 10 lines

Sorry, I missed the point. What do you try to fix? How this change fixes the issue?

I think that maybe this fix makes sense. But it needs to describe it more deeply. Could you describe the fix with more details?

Thanks,
Vyacheslav Dubeyko.

Quoted 6 lines

About this change, I also have two comments to make, one stylistic, one logical - you basically removed the ''#if 0", so I'd like to know how the "#if 0" came to be in the first place - I just haven't got the time to look through 'git blame' yet. Dead code should be removed, and that wasn't removed probably because it was too old i.e. already there for years.

"#if 0" has been there since the code was submitted to the kernel.

Quoted 3 lines

Also there is no need to add those braces {}. I believe the kernel coding guideline explicitly stated not to, for one-statement bodies in loops?

Only for if statements (if I understand the coding style right).