Skip to contentSkip to conversation

alsa: hda_codec: fix number of devices query on hotplug

PATCH Applied [email protected] 2 participants 2 messages Jun 9, 2015 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 alsa: hda_codec: fix number of devices query on hotplug

From: Dave Airlie <[email protected]>

The new regmap code seems to cache this, which isn't helpful for the hotplug dock situation where this gets updated.

Use the uncached query for this.

---
 sound/pci/hda/hda_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/hda_codec.c +1 -1
index b49feff..b778221 100644
@@ -436,7 +436,7 @@ static unsigned int get_num_devices(struct hda_codec *codec, hda_nid_t nid)
 	    get_wcaps_type(wcaps) != AC_WID_PIN)
 		return 0;
 
-	parm = snd_hda_param_read(codec, nid, AC_PAR_DEVLIST_LEN);
+	parm = snd_hdac_read_parm_uncached(&codec->core, nid, AC_PAR_DEVLIST_LEN);
 	if (parm == -1 && codec->bus->rirb_error)
 		parm = 0;
 	return parm & AC_DEV_LIST_LEN_MASK;
Signature · 1 line
2.4.1
Applied
#1 lore raw

At Tue, 9 Jun 2015 13:39:31 +1000,

Quoted 9 lines · [email protected] wrote:

From: Dave Airlie <[email protected]>

The new regmap code seems to cache this, which isn't helpful for the hotplug dock situation where this gets updated.

Use the uncached query for this.

Applied, thanks!

Takashi

Quoted 25 lines
---
 sound/pci/hda/hda_codec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/hda_codec.c +1 -1
index b49feff..b778221 100644
@@ -436,7 +436,7 @@ static unsigned int get_num_devices(struct hda_codec *codec, hda_nid_t nid)
 	    get_wcaps_type(wcaps) != AC_WID_PIN)
 		return 0;
 
-	parm = snd_hda_param_read(codec, nid, AC_PAR_DEVLIST_LEN);
+	parm = snd_hdac_read_parm_uncached(&codec->core, nid, AC_PAR_DEVLIST_LEN);
 	if (parm == -1 && codec->bus->rirb_error)
 		parm = 0;
 	return parm & AC_DEV_LIST_LEN_MASK;
Signature · 6 lines
2.4.1

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel