Skip to contentSkip to conversation

tpm, tpm_crb: fix le64_to_cpu conversions in crb_acpi_add()

PATCH In review Jarkko Sakkinen 2 participants 3 messages Jun 9, 2015 – Jun 10, 2015 TPM device driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tpm, tpm_crb: fix le64_to_cpu conversions in crb_acpi_add()

---
 drivers/char/tpm/tpm_crb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/char/tpm/tpm_crb.c +2 -2
index b26ceee..44f9d20 100644
@@ -267,7 +267,7 @@ static int crb_acpi_add(struct acpi_device *device)
 
 	memcpy_fromio(&pa, &priv->cca->cmd_pa, 8);
 	pa = le64_to_cpu(pa);
-	priv->cmd = devm_ioremap_nocache(dev, le64_to_cpu(pa),
+	priv->cmd = devm_ioremap_nocache(dev, pa,
 					 ioread32(&priv->cca->cmd_size));
 	if (!priv->cmd) {
 		dev_err(dev, "ioremap of the command buffer failed\n");
@@ -276,7 +276,7 @@ static int crb_acpi_add(struct acpi_device *device)
 
 	memcpy_fromio(&pa, &priv->cca->rsp_pa, 8);
 	pa = le64_to_cpu(pa);
-	priv->rsp = devm_ioremap_nocache(dev, le64_to_cpu(pa),
+	priv->rsp = devm_ioremap_nocache(dev, pa,
 					 ioread32(&priv->cca->rsp_size));
 	if (!priv->rsp) {
 		dev_err(dev, "ioremap of the response buffer failed\n");
Signature · 1 line
2.1.4
Reviewed-by on v1 1/1
#1 lore raw

On Tue, Jun 09, 2015 at 02:36:49PM +0300, Jarkko Sakkinen wrote:

Needs a commit message, bug description, Fixes: header and does it go to -stable ?

Quoted 4 lines
 drivers/char/tpm/tpm_crb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Obviously there is a problem here with the double swap. But that should be a nop on x86 hardware, I didn't think there was a BE arch using ACPI??

Jason

#2 lore raw
Quoted 5 lines · Jason Gunthorpe

On Tue, Jun 09, 2015 at 02:36:49PM +0300, Jarkko Sakkinen wrote:

Needs a commit message, bug description, Fixes: header and does it go to -stable ?

Quoted 8 lines
Quoted 4 lines
 drivers/char/tpm/tpm_crb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Obviously there is a problem here with the double swap. But that should be a nop on x86 hardware, I didn't think there was a BE arch using ACPI??

No but I don't want to write CRB driver assuming that CRB will be only used on LE platform like x86 even though current HW implementations are only on x86.

Quoted 3 lines

Jason

/Jarkko