Limit CHV max cdclk
Subsystems (2)
PATCH v2 1/1 Limit CHV max cdclk
For Cherryview the CD clock is limited up
to 320MHz.
Mika Kahola (1):
drm/i915: Limit CHV max cdclk
drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/1 drm/i915: Limit CHV max cdclk
Limit CHV maximum cdclk to 320MHz.
v2: Rebase to the latest
--- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
@@ -5647,7 +5647,7 @@ static void intel_update_max_cdclk(struct drm_device *dev)else dev_priv->max_cdclk_freq =675000 ; }else if (IS_VALLEYVIEW (dev)) { - dev_priv->max_cdclk_freq =400000 ; + dev_priv->max_cdclk_freq =IS_CHERRYVIEW (dev) ?320000 :400000 ; }else {/* otherwise assume cdclk is fixed */ dev_priv->max_cdclk_freq = dev_priv->cdclk_freq;
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerRe: [PATCH v2] drm/i915: Limit CHV max cdclk
Quoted 14 lines · Mika Kahola
Limit CHV maximum cdclk to 320MHz.
v2: Rebase to the latest
Signed-off-by Mika Kahola <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_display.c +0
-0
drivers/gpu/drm/i915/intel_display.c static void intel_update_max_cdclk(struct drm_device *dev) · line 5650
Quoted 5 lines
drivers/gpu/drm/i915/intel_display.c +1
-1@@ -5647,7 +5647,7 @@ static void intel_update_max_cdclk(struct drm_device *dev)else dev_priv->max_cdclk_freq =675000 ; }else if (IS_VALLEYVIEW (dev)) { - dev_priv->max_cdclk_freq =400000 ; + dev_priv->max_cdclk_freq =IS_CHERRYVIEW (dev) ?320000 :400000 ;
I'd rather make this:
} else if (IS_CHERRYVIEW(dev)) {
dev_priv->max_cdclk_freq = 320000;
} else if (IS_VALLEYVIEW(dev)) {
dev_priv->max_cdclk_freq = 400000;
} else {BR,
Jani.
Quoted 9 lines
drivers/gpu/drm/i915/intel_display.c +0
-0/* otherwise assume cdclk is fixed */ dev_priv->max_cdclk_freq = dev_priv->cdclk_freq;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2] drm/i915: Limit CHV max cdclk
Quoted 23 lines · Jani Nikula
Quoted 14 lines · Mika Kahola
Limit CHV maximum cdclk to 320MHz.
v2: Rebase to the latest
Signed-off-by Mika Kahola <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_display.c +0
-0drivers/gpu/drm/i915/intel_display.c static void intel_update_max_cdclk(struct drm_device *dev) · line 5650
Quoted 5 lines
drivers/gpu/drm/i915/intel_display.c +1
-1@@ -5647,7 +5647,7 @@ static void intel_update_max_cdclk(struct drm_device *dev)else dev_priv->max_cdclk_freq =675000 ; }else if (IS_VALLEYVIEW (dev)) { - dev_priv->max_cdclk_freq =400000 ; + dev_priv->max_cdclk_freq =IS_CHERRYVIEW (dev) ?320000 :400000 ;I'd rather make this:
Quoted 8 lines
} else if (IS_CHERRYVIEW(dev)) { dev_priv->max_cdclk_freq = 320000; } else if (IS_VALLEYVIEW(dev)) { dev_priv->max_cdclk_freq = 400000; } else {BR,
Jani.
It's probably more readable that way. I'll revise the patch.
Cheers,
Mika
Quoted 11 lines
Quoted 10 lines
drivers/gpu/drm/i915/intel_display.c +0
-0/* otherwise assume cdclk is fixed */ dev_priv->max_cdclk_freq = dev_priv->cdclk_freq;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH v2] drm/i915: Limit CHV max cdclk
In reply to Mika KaholaTask id: 6567 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 276/276 276/276 ILK 303/303 303/303 SNB 312/312 312/312 IVB 343/343 343/343 BYT 287/287 287/287 BDW 321/321 321/321
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx