Skip to contentSkip to conversation

Patch "net: dp83640: fix broken calibration routine." has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Jun 13, 2015

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net: dp83640: fix broken calibration routine.

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-dp83640-fix-broken-calibration-routine.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Sat Jun 13 09:49:06 PDT 2015

From: Richard Cochran <[email protected]>
Date: Mon, 25 May 2015 11:55:43 +0200
Subject: net: dp83640: fix broken calibration routine.

From: Richard Cochran <[email protected]>

[ Upstream commit 397a253af5031de4a4612210055935309af4472c ]

Currently, the calibration function that corrects the initial offsets among multiple devices only works the first time. If the function is called more than once, the calibration fails and bogus offsets will be programmed into the devices.

In a well hidden spot, the device documentation tells that trigger indexes 0 and 1 are special in allowing the TRIG_IF_LATE flag to actually work.

This patch fixes the issue by using one of the special triggers during the recalibration method.

---
 drivers/net/phy/dp83640.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/dp83640.c +1 -1
@@ -45,7 +45,7 @@
 #define PSF_TX		0x1000
 #define EXT_EVENT	1
 #define CAL_EVENT	7
-#define CAL_TRIGGER	7
+#define CAL_TRIGGER	1
 #define PER_TRIGGER	6
 
 #define MII_DP83640_MICR 0x11

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/net-dp83640-reinforce-locking-rules.patch queue-3.14/net-dp83640-fix-broken-calibration-routine.patch