Skip to contentSkip to conversation

pktgen: fix typos in pktgen_bench_xmit_mode_netif_receive.sh

PATCH In review Igor Vuk 2 participants 2 messages Jun 14, 2015 Networking

lore
Share & tools
lore

Igor Vuk

author
#0 lore raw

PATCH 1/1 pktgen: fix typos in pktgen_bench_xmit_mode_netif_receive.sh

Fixes some typos in pktgen_bench_xmit_mode_netif_receive.sh, also does some minor reformatting so the original layout is preserved.

---
 samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh +4 -4
index cb15903..a25525e 100755
@@ -7,9 +7,9 @@
 # "xmit_mode netif_receive".  With an invalid dst_mac this will only
 # measure the ingress code path as packets gets dropped in ip_rcv().
 #
-# This script don't really need any hardware.  It benchmarks software
-# RX path just after NIC driver level.  With bursting is also
-# "removes" the SKB alloc/free overhead.
+# This script doesn't really need any hardware.  It benchmarks
+# software RX path just after NIC driver level.  With bursting it
+# also "removes" the SKB alloc/free overhead.
 #
 # Setup scenarios for measuring ingress qdisc (with invalid dst_mac):
 # ------------------------------------------------------------------
@@ -69,7 +69,7 @@ for ((thread = 0; thread < $THREADS; thread++)); do
     # Inject packet into RX path of stack
     pg_set $dev "xmit_mode netif_receive"
 
-    # Burst allow us to avoid measuring SKB alloc/free overhead
+    # Burst allows us to avoid measuring SKB alloc/free overhead
     pg_set $dev "burst $BURST"
 done
 
Signature · 1 line
2.1.4
Acked-by on v1 1/1
#1 lore raw
Quoted 27 lines · On Sun, 14 Jun 2015 11:43:38 +0200 Igor Vuk <[email protected]> wrote:

Fixes some typos in pktgen_bench_xmit_mode_netif_receive.sh, also does some minor reformatting so the original layout is preserved.

---
 samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh +3 -3
index cb15903..a25525e 100755
@@ -7,9 +7,9 @@
 # "xmit_mode netif_receive".  With an invalid dst_mac this will only
 # measure the ingress code path as packets gets dropped in ip_rcv().
 #
-# This script don't really need any hardware.  It benchmarks software
-# RX path just after NIC driver level.  With bursting is also
-# "removes" the SKB alloc/free overhead.
+# This script doesn't really need any hardware.  It benchmarks
+# software RX path just after NIC driver level.  With bursting it
+# also "removes" the SKB alloc/free overhead.
 #
 # Setup scenarios for measuring ingress qdisc (with invalid dst_mac):
 # ------------------------------------------------------------------

samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh for ((thread = 0; thread < $THREADS; thread++)); do · line 73

Quoted 6 lines
samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh +1 -1
@@ -69,7 +69,7 @@ for ((thread = 0; thread < $THREADS; thread++)); do
     # Inject packet into RX path of stack
     pg_set $dev "xmit_mode netif_receive"
 
-    # Burst allow us to avoid measuring SKB alloc/free overhead
+    # Burst allows us to avoid measuring SKB alloc/free overhead
     pg_set $dev "burst $BURST"
Signature · 5 lines
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer