Skip to contentSkip to conversation

Android.mk: Disable tools that do not build for android

PATCH Superseded Derek Morton 4 participants 7 messages Jun 15, 2015

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Android.mk: Disable tools that do not build for android

Disable the tools / demo code that do not currently build for android until they can be fixed.

Affected tools / demos
intel_reg
intel_display_crc
intel_sprite_on

---
 Android.mk       | 2 +-
 tools/Android.mk | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
Android.mk +1 -1
index 1ab3e64..681d114 100644
@@ -1,2 +1,2 @@
-include $(call all-named-subdir-makefiles, lib tests tools benchmarks demos)
+include $(call all-named-subdir-makefiles, lib tests tools benchmarks)
 
tools/Android.mk +2 -0
index 39f4512..fd2800e 100644
@@ -36,7 +36,9 @@ endef
 #================#
 
 skip_tools_list := \
+    intel_display_crc \
     intel_framebuffer_dump \
+    intel_reg \
     intel_reg_dumper \
     intel_vga_read \
     intel_vga_write
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 2 lines · Derek Morton

Disable the tools / demo code that do not currently build for android until they can be fixed.

What needs to be fixed?

Quoted 35 lines

Affected tools / demos
intel_reg
intel_display_crc
intel_sprite_on

---
 Android.mk       | 2 +-
 tools/Android.mk | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
Android.mk +1 -1
index 1ab3e64..681d114 100644
@@ -1,2 +1,2 @@
-include $(call all-named-subdir-makefiles, lib tests tools benchmarks demos)
+include $(call all-named-subdir-makefiles, lib tests tools benchmarks)
 
tools/Android.mk +2 -1
index 39f4512..fd2800e 100644
@@ -36,7 +36,9 @@ endef
 #================#
 
 skip_tools_list := \
+    intel_display_crc \
     intel_framebuffer_dump \
+    intel_reg \
     intel_reg_dumper \
     intel_vga_read \
     intel_vga_write
--
Quoted 2 lines

1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 8 lines

-----Original Message-----
From: Thomas Wood [mailto:[email protected]]
Sent: Monday, June 15, 2015 2:09 PM
To: Morton, Derek J
Cc: Intel Graphics Development; Gore, Tim
Subject: Re: [PATCH i-g-t] Android.mk: Disable tools that do not build for android

Quoted 6 lines
Quoted 2 lines · Derek Morton

Disable the tools / demo code that do not currently build for android until they can be fixed.

What needs to be fixed?

Intel_reg - Relies on a header file not provided by the Android compiler Intel_display_crc - Cairo dependency
Intel_sprite_on - An API difference in the Android i915 driver.

//Derek

Quoted 30 lines
Quoted 30 lines

Affected tools / demos
intel_reg
intel_display_crc
intel_sprite_on

---
 Android.mk       | 2 +-
 tools/Android.mk | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
Android.mk +2 -1
index 1ab3e64..681d114 100644
@@ -1,2 +1,2 @@
-include $(call all-named-subdir-makefiles, lib tests tools benchmarks 
 demos)
+include $(call all-named-subdir-makefiles, lib tests tools 
+benchmarks)
tools/Android.mk index renamed from tools/Android.mk +0 -0

39f4512..fd2800e 100644

tools/Android.mk +0 -0
@@ -36,7 +36,9 @@ endef
 #================#
 
Quoted 11 lines
Quoted 10 lines
tools/Android.mk +2 -1
 skip_tools_list := \
+    intel_display_crc \
     intel_framebuffer_dump \
+    intel_reg \
     intel_reg_dumper \
     intel_vga_read \
     intel_vga_write
--

1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 8 lines · Derek J
Quoted 8 lines

-----Original Message-----
From: Thomas Wood [mailto:[email protected]]
Sent: Monday, June 15, 2015 2:09 PM
To: Morton, Derek J
Cc: Intel Graphics Development; Gore, Tim
Subject: Re: [PATCH i-g-t] Android.mk: Disable tools that do not build for android

Quoted 8 lines
Quoted 6 lines · Derek Morton
Quoted 2 lines

Disable the tools / demo code that do not currently build for android until they can be fixed.

What needs to be fixed?

Intel_reg - Relies on a header file not provided by the Android compiler

...which one?

Quoted 50 lines

Intel_display_crc - Cairo dependency
Intel_sprite_on - An API difference in the Android i915 driver.

//Derek

Quoted 30 lines
Quoted 30 lines

Affected tools / demos
intel_reg
intel_display_crc
intel_sprite_on

---
 Android.mk       | 2 +-
 tools/Android.mk | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
Android.mk +2 -1
index 1ab3e64..681d114 100644
@@ -1,2 +1,2 @@
-include $(call all-named-subdir-makefiles, lib tests tools benchmarks 
 demos)
+include $(call all-named-subdir-makefiles, lib tests tools 
+benchmarks)
tools/Android.mk index renamed from tools/Android.mk +0 -0

39f4512..fd2800e 100644

tools/Android.mk +0 -0
@@ -36,7 +36,9 @@ endef
 #================#
 
Quoted 11 lines
Quoted 10 lines
tools/Android.mk +2 -1
 skip_tools_list := \
+    intel_display_crc \
     intel_framebuffer_dump \
+    intel_reg \
     intel_reg_dumper \
     intel_vga_read \
     intel_vga_write
--

1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 23 lines

-----Original Message-----
From: Jani Nikula [mailto:[email protected]]
Sent: Monday, June 15, 2015 2:24 PM
To: Morton, Derek J; Wood, Thomas
Cc: Intel Graphics Development
Subject: Re: [Intel-gfx] [PATCH i-g-t] Android.mk: Disable tools that do not build for android

Quoted 13 lines · Derek J
Quoted 13 lines

-----Original Message-----
From: Thomas Wood [mailto:[email protected]]
Sent: Monday, June 15, 2015 2:09 PM
To: Morton, Derek J
Cc: Intel Graphics Development; Gore, Tim
Subject: Re: [PATCH i-g-t] Android.mk: Disable tools that do not build for android

Quoted 2 lines · Derek Morton

Disable the tools / demo code that do not currently build for android until they can be fixed.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

What needs to be fixed?

Intel_reg - Relies on a header file not provided by the Android compiler

...which one?

sys/io.h
Tim Gore has looked into this issue. The complexity in fixing is more with the licencing than technical.

//Derek

Quoted 47 lines
Quoted 47 lines

Intel_display_crc - Cairo dependency
Intel_sprite_on - An API difference in the Android i915 driver.

//Derek

Quoted 41 lines
Quoted 40 lines

Affected tools / demos
intel_reg
intel_display_crc
intel_sprite_on

---
 Android.mk       | 2 +-
 tools/Android.mk | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
Android.mk +0 -1
@@ -1,2 +1,2 @@
-include $(call all-named-subdir-makefiles, lib tests tools 

benchmarks
demos)

Android.mk +2 -0
+include $(call all-named-subdir-makefiles, lib tests tools
+benchmarks)
tools/Android.mk index renamed from tools/Android.mk +0 -0

39f4512..fd2800e 100644

tools/Android.mk +2 -1
@@ -36,7 +36,9 @@ endef
 #================#
 
 skip_tools_list := \
+    intel_display_crc \
     intel_framebuffer_dump \
+    intel_reg \
     intel_reg_dumper \
     intel_vga_read \
     intel_vga_write
--

1.9.1

Quoted 8 lines
Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Jani Nikula, Intel Open Source Technology Center

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
In reply to Morton, Derek J
Quoted 9 lines · Derek J
Quoted 9 lines

-----Original Message-----
From: Thomas Wood [mailto:[email protected]]
Sent: Monday, June 15, 2015 2:09 PM
To: Morton, Derek J
Cc: Intel Graphics Development; Gore, Tim
Subject: Re: [PATCH i-g-t] Android.mk: Disable tools that do not build for android

On 15 June 2015 at 14:04, Derek Morton <[email protected]> wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Disable the tools / demo code that do not currently build for android until they can be fixed.

What needs to be fixed?

Intel_reg - Relies on a header file not provided by the Android compiler Intel_display_crc - Cairo dependency

Cairo should be available by now on android, at least on some builds. The test at least go to great pains to build if cairo is around. Imo we should adopt it.

Quoted 1 line

Intel_sprite_on - An API difference in the Android i915 driver.

This tool is only around for the benefit of the android display folks. If you dont need it then it's time to remove it.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw
Quoted 23 lines

-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Monday, June 15, 2015 2:43 PM
To: Morton, Derek J
Cc: Wood, Thomas; Intel Graphics Development
Subject: Re: [Intel-gfx] [PATCH i-g-t] Android.mk: Disable tools that do not build for android

Quoted 13 lines · Derek J
Quoted 13 lines

-----Original Message-----
From: Thomas Wood [mailto:[email protected]]
Sent: Monday, June 15, 2015 2:09 PM
To: Morton, Derek J
Cc: Intel Graphics Development; Gore, Tim
Subject: Re: [PATCH i-g-t] Android.mk: Disable tools that do not build for android

Quoted 2 lines · Derek Morton

Disable the tools / demo code that do not currently build for android until they can be fixed.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

What needs to be fixed?

Intel_reg - Relies on a header file not provided by the Android compiler Intel_display_crc - Cairo dependency

Cairo should be available by now on android, at least on some builds. The test at least go to great pains to build if cairo is around. Imo we should adopt it.

Cairo is not present by default on the Gmin build. There is a CAIRO_DEPENDANT flag for building tests. I will update the patch so the tool gets built conditionally with the same flag.

Quoted 5 lines
Quoted 2 lines

Intel_sprite_on - An API difference in the Android i915 driver.

This tool is only around for the benefit of the android display folks. If you dont need it then it's time to remove it. -Daniel

My aim is to get the vanilla freedesktop code to build on android. Currently intel_sprit_on requires a local patch to build so needs to be disabled by default until that is resolved.

//Derek

Quoted 5 lines

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx