Skip to contentSkip to conversation

ASoC: DAPM: fix build errors for missing snd_soc_dapm_new_control symbol

PATCH In review Liam Girdwood 3 participants 5 messages Jun 15, 2015 – Jun 16, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: DAPM: fix build errors for missing snd_soc_dapm_new_control symbol

Fix the following error:-

All error/warnings (new ones prefixed by >>):

Quoted 3 lines

sound/built-in.o: In function `soc_tplg_dapm_widget_create':

Quoted 1 line
Quoted 1 line

:(.text+0x25a90): undefined reference to `snd_soc_dapm_new_control'

---
 sound/soc/soc-dapm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/soc-dapm.c +2 -2
index 92d57a9..1b4a6eb 100644
@@ -53,7 +53,7 @@ static int snd_soc_dapm_add_path(struct snd_soc_dapm_context *dapm,
 	int (*connected)(struct snd_soc_dapm_widget *source,
 			 struct snd_soc_dapm_widget *sink));
 
-static struct snd_soc_dapm_widget *
+struct snd_soc_dapm_widget *
 snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm,
 			 const struct snd_soc_dapm_widget *widget);
 
@@ -3270,7 +3270,7 @@ int snd_soc_dapm_put_pin_switch(struct snd_kcontrol *kcontrol,
 }
 EXPORT_SYMBOL_GPL(snd_soc_dapm_put_pin_switch);
 
-static struct snd_soc_dapm_widget *
+struct snd_soc_dapm_widget *
 snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm,
 	const struct snd_soc_dapm_widget *widget)
 {
Signature · 1 line
2.1.4
maintainer
#1 lore raw
Quoted 8 lines · Liam Girdwood

Fix the following error:-

All error/warnings (new ones prefixed by >>):

Quoted 3 lines

sound/built-in.o: In function `soc_tplg_dapm_widget_create':

Quoted 1 line
Quoted 1 line

:(.text+0x25a90): undefined reference to `snd_soc_dapm_new_control'

This doesn't apply, I appear to have this already?

#2 lore raw
Quoted 11 lines · Mark Brown
Quoted 8 lines · Liam Girdwood

Fix the following error:-

All error/warnings (new ones prefixed by >>):

Quoted 3 lines

sound/built-in.o: In function `soc_tplg_dapm_widget_create':

Quoted 1 line
Quoted 1 line

:(.text+0x25a90): undefined reference to `snd_soc_dapm_new_control'

This doesn't apply, I appear to have this already?

Oh, ok - Vinod reported it was missing earlier and I could not see it in your topic/topology either ?

Liam

maintainer
#3 lore raw
Quoted 6 lines · Liam Girdwood
Quoted 1 line · Mark Brown

This doesn't apply, I appear to have this already?

Oh, ok - Vinod reported it was missing earlier and I could not see it in your topic/topology either ?

It's a change for DAPM, it's on the DAPM branch.

#4 lore raw
Quoted 9 lines · Mark Brown
Quoted 6 lines · Liam Girdwood
Quoted 1 line · Mark Brown

This doesn't apply, I appear to have this already?

Oh, ok - Vinod reported it was missing earlier and I could not see it in your topic/topology either ?

It's a change for DAPM, it's on the DAPM branch.

Sorry for the noise, let me cherry-pick that one for testing.

Signature · 1 line
~Vinod