Skip to contentSkip to conversation

drivers/staging/comedi/drivers/pcl816.c: style fix

PATCH In review Guillermo O. Freschi 3 participants 3 messages Jun 16, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drivers/staging/comedi/drivers/pcl816.c: style fix

Removed some spaces before a tab character.

---
 drivers/staging/comedi/drivers/pcl816.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/pcl816.c +1 -1
index 1ccb2f1..781b321 100644
@@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
 
 		/*  check whole chanlist */
 		for (i = 0, segpos = 0; i < chanlen; i++) {
-			    if (chanlist[i] != chansegment[i % seglen]) {
+			if (chanlist[i] != chansegment[i % seglen]) {
 				dev_dbg(dev->class_dev,
 					"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
 					i, CR_CHAN(chansegment[i]),
Signature · 1 line
2.1.4
#1 lore raw
Quoted 13 lines · Guillermo O. Freschi

Removed some spaces before a tab character.

---
  drivers/staging/comedi/drivers/pcl816.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/pcl816.c +0 -0
index 1ccb2f1..781b321 100644

drivers/staging/comedi/drivers/pcl816.c static int check_channel_list(struct comedi_device *dev, · line 329

Quoted 8 lines
drivers/staging/comedi/drivers/pcl816.c +1 -1
@@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
 
  		/*  check whole chanlist */
  		for (i = 0, segpos = 0; i < chanlen; i++) {
-			    if (chanlist[i] != chansegment[i % seglen]) {
+			if (chanlist[i] != chansegment[i % seglen]) {
  				dev_dbg(dev->class_dev,
  					"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
  					i, CR_CHAN(chansegment[i]),

Thanks, but it's also fixed by commit 8b4e7da516aa in linux-next.

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
#2 lore raw
In reply to Guillermo O. Freschi
Quoted 3 lines · Guillermo O. Freschi

Removed some spaces before a tab character.

I should have checked when you sent your v1. This patch will not apply. This change has already been done by commit:
8b4e7da51 ("staging: comedi/drivers/pcl.* coding style fixes")

please create your patches based on staging-testing tree. and always use scripts/get_maintainer.pl to get a list of people and mailing lists to send your patch.

regards
sudip