Skip to contentSkip to conversation

Patch "MIPS: ralink: Fix clearing the illegal access interrupt" has been added to the 4.0-stable tree

PATCH [email protected] 1 participant 1 message Jun 19, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

MIPS: ralink: Fix clearing the illegal access interrupt

to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mips-ralink-fix-clearing-the-illegal-access-interrupt.patch
and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9dd6f1c166bc6e7b582f6203f2dc023ec65e3ed5 Mon Sep 17 00:00:00 2001

From: Jonas Gorski <[email protected]>
Date: Mon, 25 May 2015 19:53:54 +0200
Subject: MIPS: ralink: Fix clearing the illegal access interrupt

From: Jonas Gorski <[email protected]>

commit 9dd6f1c166bc6e7b582f6203f2dc023ec65e3ed5 upstream.

Due to a typo the illegal access interrupt is never cleared in by the interupt handler, causing an effective deadlock on the first illegal access.

This was broken since the code was introduced in 5433acd81e87 ("MIPS:
ralink: add illegal access driver"), but only exposed when the Kconfig symbol was added, thus enabling the code.

Fixes a7b7aad383c ("MIPS: ralink: add missing symbol for RALINK_ILL_ACC")
Cc John Crispin <[email protected]>

Patchwork: https://patchwork.linux-mips.org/patch/10172/

---
 arch/mips/ralink/ill_acc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/ralink/ill_acc.c +1 -1
@@ -41,7 +41,7 @@ static irqreturn_t ill_acc_irq_handler(i
 		addr, (type >> ILL_ACC_OFF_S) & ILL_ACC_OFF_M,
 		type & ILL_ACC_LEN_M);
 
-	rt_memc_w32(REG_ILL_ACC_TYPE, REG_ILL_ACC_TYPE);
+	rt_memc_w32(ILL_INT_STATUS, REG_ILL_ACC_TYPE);
 
 	return IRQ_HANDLED;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.0/mips-ralink-fix-clearing-the-illegal-access-interrupt.patch --
To unsubscribe from this list: send the line "unsubscribe stable" in