Skip to contentSkip to conversation

Patch "ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage" has been added to the 3.14-stable tree

PATCH [email protected] 2 participants 3 messages Jun 19, 2015 – Jun 22, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
arm-dts-am335x-boneblack-disable-rtc-only-sleep-to-avoid-hardware-damage.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7a6cb0abe1aa63334f3ded6d2b6c8eca80e72302 Mon Sep 17 00:00:00 2001

From: Matthijs van Duin <[email protected]>
Date: Mon, 1 Jun 2015 21:33:28 +0200
Subject: ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage

From: Matthijs van Duin <[email protected]>

commit 7a6cb0abe1aa63334f3ded6d2b6c8eca80e72302 upstream.

Avoid entering "RTC-only mode" at poweroff. It is unsupported by most versions of BeagleBone, and risks hardware damage.

The damaging configuration is having system-power-controller without ti,pmic-shutdown-controller.

Cc Tony Lindgren <[email protected]>
Cc Felipe Balbi <[email protected]>
Cc Johan Hovold <[email protected]>
[Matthijs van Duin: added explanatory comments]
[[email protected]: updated comments with the hardware breaking info]
---
 arch/arm/boot/dts/am335x-bone-common.dtsi |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
arch/arm/boot/dts/am335x-bone-common.dtsi +19 -0
@@ -226,6 +226,25 @@
 /include/ "tps65217.dtsi"
 
 &tps {
+	/*
+	 * Configure pmic to enter OFF-state instead of SLEEP-state ("RTC-only
+	 * mode") at poweroff.  Most BeagleBone versions do not support RTC-only
+	 * mode and risk hardware damage if this mode is entered.
+	 *
+	 * For details, see linux-omap mailing list May 2015 thread
+	 *	[PATCH] ARM: dts: am335x-bone* enable pmic-shutdown-controller
+	 * In particular, messages:
+	 *	http://www.spinics.net/lists/linux-omap/msg118585.html
+	 *	http://www.spinics.net/lists/linux-omap/msg118615.html
+	 *
+	 * You can override this later with
+	 *	&tps {  /delete-property/ ti,pmic-shutdown-controller;  }
+	 * if you want to use RTC-only mode and made sure you are not affected
+	 * by the hardware problems. (Tip: double-check by performing a current
+	 * measurement after shutdown: it should be less than 1 mA.)
+	 */
+	ti,pmic-shutdown-controller;
+
 	regulators {
 		dcdc1_reg: regulator@0 {
 			regulator-always-on;

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/arm-dts-am335x-boneblack-disable-rtc-only-sleep-to-avoid-hardware-damage.patch --
To unsubscribe from this list: send the line "unsubscribe stable" in

#1 lore raw
Quoted 8 lines · Greg Kroah-Hartman

This is a note to let you know that I've just added the patch titled

ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
arm-dts-am335x-boneblack-disable-rtc-only-sleep-to-avoid-hardware-damage.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

This one can be dropped from 3.14-stable as it is only needed in 3.19 and later kernels that have commit 672e2b147413 ("ARM: dts:
am335x-boneblack: enable power off and rtc wake up").

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe stable" in

author maintainer
#2 lore raw
Quoted 13 lines · Johan Hovold
Quoted 12 lines · Greg Kroah-Hartman

This is a note to let you know that I've just added the patch titled

ARM: dts: am335x-boneblack: disable RTC-only sleep to avoid hardware damage

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
arm-dts-am335x-boneblack-disable-rtc-only-sleep-to-avoid-hardware-damage.patch
and it can be found in the queue-3.14 subdirectory.

Quoted 6 lines
Quoted 2 lines

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

This one can be dropped from 3.14-stable as it is only needed in 3.19 and later kernels that have commit 672e2b147413 ("ARM: dts:
am335x-boneblack: enable power off and rtc wake up").

Thanks, now dropped.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in