Skip to contentSkip to conversation

Patch "btrfs: incorrect handling for fiemap_fill_next_extent return" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Jun 19, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

btrfs: incorrect handling for fiemap_fill_next_extent return

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
btrfs-incorrect-handling-for-fiemap_fill_next_extent-return.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 26e726afe01c1c82072cf23a5ed89ce25f39d9f2 Mon Sep 17 00:00:00 2001

From: Chengyu Song <[email protected]>
Date: Tue, 24 Mar 2015 18:12:56 -0400
Subject: btrfs: incorrect handling for fiemap_fill_next_extent return

From: Chengyu Song <[email protected]>

commit 26e726afe01c1c82072cf23a5ed89ce25f39d9f2 upstream.

fiemap_fill_next_extent returns 0 on success, -errno on error, 1 if this was the last extent that will fit in user array. If 1 is returned, the return value may eventually returned to user space, which should not happen, according to manpage of ioctl.

---
 fs/btrfs/extent_io.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
fs/btrfs/extent_io.c +4 -1
@@ -4289,8 +4289,11 @@ int extent_fiemap(struct inode *inode, s
 		}
 		ret = fiemap_fill_next_extent(fieinfo, em_start, disko,
 					      em_len, flags);
-		if (ret)
+		if (ret) {
+			if (ret == 1)
+				ret = 0;
 			goto out_free;
+		}
 	}
 out_free:
 	free_extent_map(em);

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/btrfs-incorrect-handling-for-fiemap_fill_next_extent-return.patch --
To unsubscribe from this list: send the line "unsubscribe stable" in