Skip to contentSkip to conversation

sna: Correct misspelled cacheing->caching in comments

PATCH In review Sedat Dilek 3 participants 4 messages Jun 23, 2015 – Jul 2, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sna: Correct misspelled cacheing->caching in comments

I have seen this typo once and added an entry to codespell's dictionary.txt file.

$ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
--- /usr/share/codespell/dictionary.txt.orig    2015-06-09 20:49:25.000000000 +0200
+++ /usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200
@@ -625,6 +625,7 @@ burried->buried
 busineses->business, businesses,
 busness->business
 bussiness->business
+cacheing->caching
 caculater->calculator
 cacuses->caucuses
 cahracters->characters

There some other places where this typo occurs:

[ src/sna/kgem.c ]

298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo) 324:#define assert_cacheing(kgem, bo)
2455: assert_cacheing(kgem, bo);
2841: assert_cacheing(kgem, bo);

It's up to Chris what to do with this.

---
 src/sna/sna_dri2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
src/sna/sna_dri2.c +2 -2
index 2cde0c6aa0dc..2a1f8475b735 100644
@@ -228,7 +228,7 @@ sna_dri2_cache_bo(struct sna *sna,
 	if (!c)
 		goto err;
 
-	DBG(("%s: cacheing handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, bo->handle, name, flags, bo->active_scanout));
+	DBG(("%s: caching handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, bo->handle, name, flags, bo->active_scanout));
 
 	c->bo = bo;
 	c->name = name;
@@ -333,7 +333,7 @@ sna_dri2_get_back(struct sna *sna,
 			c->name = back->name;
 			c->flags = back->flags;
 			list_add(&c->link, &priv->cache);
-			DBG(("%s: cacheing handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, c->bo->handle, c->name, c->flags, c->bo->active_scanout));
+			DBG(("%s: caching handle=%d (name=%d, flags=%d, active_scanout=%d)\n", __FUNCTION__, c->bo->handle, c->name, c->flags, c->bo->active_scanout));
 		}
 	} else {
 		if (&c->link != &priv->cache)
Signature · 6 lines
2.4.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 16 lines · Sedat Dilek

I have seen this typo once and added an entry to codespell's dictionary.txt file.

$ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200 renamed from usr/share/codespell/dictionary.txt.orig 2015-06-09 20:49:25.000000000 +0200 +1 -0
@@ -625,6 +625,7 @@ burried->buried
 busineses->business, businesses,
 busness->business
 bussiness->business
+cacheing->caching
 caculater->calculator
 cacuses->caucuses
 cahracters->characters

There some other places where this typo occurs:

Quoted 8 lines

[ src/sna/kgem.c ]

298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo) 324:#define assert_cacheing(kgem, bo)
2455: assert_cacheing(kgem, bo);
2841: assert_cacheing(kgem, bo);

It's up to Chris what to do with this.

I just can't get paste reading 'caching' as two hard Cs and so it feels weird.

commit f414ed4e40292e91e9c6850fb01a26334e6b43c7

Author: Chris Wilson <[email protected]>
Date:   Wed Jun 24 11:02:28 2015 +0100

sna: Fix misspelling of "caching"

Apply s/cacheing/caching/ because I am alone in my belief of how to spell cacheing correctly :)

Thanks,
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 24 lines · Chris Wilson
Quoted 23 lines · Sedat Dilek

I have seen this typo once and added an entry to codespell's dictionary.txt file.

$ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200 renamed from usr/share/codespell/dictionary.txt.orig 2015-06-09 20:49:25.000000000 +0200 +1 -0
@@ -625,6 +625,7 @@ burried->buried
 busineses->business, businesses,
 busness->business
 bussiness->business
+cacheing->caching
 caculater->calculator
 cacuses->caucuses
 cahracters->characters

There some other places where this typo occurs:

[ src/sna/kgem.c ]

298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo) 324:#define assert_cacheing(kgem, bo)
2455: assert_cacheing(kgem, bo);
2841: assert_cacheing(kgem, bo);

Quoted 4 lines
Quoted 1 line

It's up to Chris what to do with this.

I just can't get past reading 'caching' as two hard Cs and so it feels weird.

That would be Italian. Cache (and "cachet") come from French "cacher" (to hide), so the "ch" is (almost) the same as in "chef" or "chauffeur".

We could switch to using the Esperanto spelling, "kaŝi" and the corresponding hardware term "kaŝmemoro" :)

.Dave.
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Chris Wilson
Quoted 33 lines · Chris Wilson
Quoted 16 lines · Sedat Dilek

I have seen this typo once and added an entry to codespell's dictionary.txt file.

$ diff -uprN /usr/share/codespell/dictionary.txt.orig /usr/share/codespell/dictionary.txt
usr/share/codespell/dictionary.txt 2015-06-23 07:37:35.893689539 +0200 renamed from usr/share/codespell/dictionary.txt.orig 2015-06-09 20:49:25.000000000 +0200 +1 -0
@@ -625,6 +625,7 @@ burried->buried
 busineses->business, businesses,
 busness->business
 bussiness->business
+cacheing->caching
 caculater->calculator
 cacuses->caucuses
 cahracters->characters

There some other places where this typo occurs:

Quoted 8 lines

[ src/sna/kgem.c ]

298:static void assert_cacheing(struct kgem *kgem, struct kgem_bo *bo) 324:#define assert_cacheing(kgem, bo)
2455: assert_cacheing(kgem, bo);
2841: assert_cacheing(kgem, bo);

It's up to Chris what to do with this.

I just can't get paste reading 'caching' as two hard Cs and so it feels weird.

commit f414ed4e40292e91e9c6850fb01a26334e6b43c7

Author: Chris Wilson <[email protected]>
Date:   Wed Jun 24 11:02:28 2015 +0100
Quoted 8 lines

sna: Fix misspelling of "caching"

Apply s/cacheing/caching/ because I am alone in my belief of how to spell cacheing correctly :)

Thanks.

Just FYI... codespell got it, now.

commit b003c6167fdf441d2ba89534d402015723b66560
"Add misspelled cacheing->caching"

- sed@ -

[1] https://github.com/lucasdemarchi/codespell/commit/b003c6167fdf441d2ba89534d402015723b66560
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx