Skip to contentSkip to conversation

drm/i915/gen9: fix typo when setting up the crtc scaler

PATCH In review Imre Deak 3 participants 3 messages Jun 23, 2015

Subsystems (2)
lore
Share & tools
lore

Imre Deak

author
#0 lore raw

PATCH 1/1 drm/i915/gen9: fix typo when setting up the crtc scaler

This typo lead to the crtc scaler getting enabled incorrectly and an evantual state checker mismatch about the scaler_id.

---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
index 6dabc1c..7f2167e 100644
@@ -4368,7 +4368,7 @@ int skl_update_scaler_crtc(struct intel_crtc_state *state, int force_detach)
 	return skl_update_scaler(state, force_detach, SKL_CRTC_INDEX,
 		&state->scaler_state.scaler_id, DRM_ROTATE_0,
 		state->pipe_src_w, state->pipe_src_h,
-		adjusted_mode->hdisplay, adjusted_mode->hdisplay);
+		adjusted_mode->hdisplay, adjusted_mode->vdisplay);
 }
 
 /**
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Imre Deak

This typo lead to the crtc scaler getting enabled incorrectly and an evantual state checker mismatch about the scaler_id.

Signature · 1 line
Damien
Quoted 24 lines
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
index 6dabc1c..7f2167e 100644
@@ -4368,7 +4368,7 @@ int skl_update_scaler_crtc(struct intel_crtc_state *state, int force_detach)
 	return skl_update_scaler(state, force_detach, SKL_CRTC_INDEX,
 		&state->scaler_state.scaler_id, DRM_ROTATE_0,
 		state->pipe_src_w, state->pipe_src_h,
-		adjusted_mode->hdisplay, adjusted_mode->hdisplay);
+		adjusted_mode->hdisplay, adjusted_mode->vdisplay);
 }
 
 /**
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 7 lines · Damien Lespiau
Quoted 4 lines · Imre Deak

This typo lead to the crtc scaler getting enabled incorrectly and an evantual state checker mismatch about the scaler_id.

Hooray for pipe state checker! Queued for -next, thanks for the patch. -Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx