Skip to contentSkip to conversation

Patch "perf tools: Fix build breakage if prefix= is specified" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Jun 26, 2015 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

perf tools: Fix build breakage if prefix= is specified

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
perf-tools-fix-build-breakage-if-prefix-is-specified.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 75e84ab906ef8935cff3df3d8929f1bafea81599 Mon Sep 17 00:00:00 2001

From: Lukas Wunner <[email protected]>
Date: Thu, 18 Jun 2015 13:00:32 +0200
Subject: perf tools: Fix build breakage if prefix= is specified

From: Lukas Wunner <[email protected]>

commit 75e84ab906ef8935cff3df3d8929f1bafea81599 upstream.

Invoking Makefile.perf with prefix= breaks the build since Makefile.perf hands that variable down to Makefile.build where it overrides

    prefix       := $(subst ./,,$(OUTPUT)$(dir)/)

leading to errors like this:

No rule to make target '/usrabspath.o', needed by '/usrlibperf-in.o'

---
 tools/build/Makefile.build |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
tools/build/Makefile.build +4 -4
@@ -94,12 +94,12 @@ obj-y        := $(patsubst %/, %/$(obj)-
 subdir-obj-y := $(filter %/$(obj)-in.o, $(obj-y))
 
 # '$(OUTPUT)/dir' prefix to all objects
-prefix       := $(subst ./,,$(OUTPUT)$(dir)/)
-obj-y        := $(addprefix $(prefix),$(obj-y))
-subdir-obj-y := $(addprefix $(prefix),$(subdir-obj-y))
+objprefix    := $(subst ./,,$(OUTPUT)$(dir)/)
+obj-y        := $(addprefix $(objprefix),$(obj-y))
+subdir-obj-y := $(addprefix $(objprefix),$(subdir-obj-y))
 
 # Final '$(obj)-in.o' object
-in-target := $(prefix)$(obj)-in.o
+in-target := $(objprefix)$(obj)-in.o
 
 PHONY += $(subdir-y)
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/perf-tools-fix-build-breakage-if-prefix-is-specified.patch