Skip to contentSkip to conversation

xhci:Change function name from xhci_configure_endpoint_result to xhci_trace_endpoint_result

PATCH Greg KH 1 participant 1 message Jun 26, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author
#1 lore raw
Quoted 7 lines · Nicholas Krause

This changes the name of the function xhci_configure_endpoint_result to xhci_trace_endpoint_result to more clearly state the actual intended use of this function which is tracing the passed command status, on the passed usb/xhci structure pointers of udev and xhci respectfully.

Dammit, my filters broke, I need to go fix them now...

Quoted 18 lines
---
 drivers/usb/host/xhci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/host/xhci.c +1 -1
index 36bf089..2e086ef 100644
@@ -1839,7 +1839,7 @@ static void xhci_zero_in_ctx(struct xhci_hcd *xhci, struct xhci_virt_device *vir
 	}
 }
 
-static int xhci_configure_endpoint_result(struct xhci_hcd *xhci,
+static int xhci_trace_endpoint_result(struct xhci_hcd *xhci,
 		struct usb_device *udev, u32 *cmd_status)
 {
 	int ret;

drivers/usb/host/xhci.c static int xhci_configure_endpoint(struct xhci_hcd *xhci, · line 2687

Quoted 6 lines
drivers/usb/host/xhci.c +1 -1
@@ -2683,7 +2683,7 @@ static int xhci_configure_endpoint(struct xhci_hcd *xhci,
 	wait_for_completion(command->completion);
 
 	if (!ctx_change)
-		ret = xhci_configure_endpoint_result(xhci, udev,
+		ret = xhci_trace_endpoint_result(xhci, udev,
 						     &command->status);

No, please stop, this is doing nothing but unneeded code churn, and do absolutely nothing.

Because you are banned from vger, these patches are not being sent to the public, so I will not accept them either.

I will not be accepting any patches from you for at least a year, maybe two, so don't waste your time. Please go work on some other open source project, if you really want to contribute to the Linux ecosystem, as long as it is not the kernel.

greg k-h