Skip to contentSkip to conversation

tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

PATCH In review Saul Wold 3 participants 3 messages Jun 29, 2015 – Jul 2, 2015

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

PATCH 1/1 tune-i586-nlp: Add new tune file to support Quark/X1000 CPU

This tune file is needed to enable a GAS option specific to this cpu family in order to disable the usage of lock prefix instructions.

---
 meta/conf/machine/include/tune-i586-nlp.inc | 19 +++++++++++++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-i586-nlp.inc
meta/conf/machine/include/tune-i586-nlp.inc new file +19 -0
new file mode 100644
index 0000000..94e22c1
@@ -0,0 +1,19 @@
+# Settings for the GCC(1) cpu-type "quark":
+#
+#
+#
+DEFAULTTUNE ?= "i586-nlp-32"
+
+# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
+require conf/machine/include/x86/arch-x86.inc
+
+# x86 with no lock prefix
+TUNEVALID[i586-nlp] = "IA32 with Lock Prefix omitted"
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "i586-nlp", " -march=i586 -Wa,-momit-lock-prefix=yes", "", d)}"
+
+# Quark tune feature
+AVAILTUNES = "i586-nlp-32"
+TUNE_FEATURES_tune-i586-nlp-32 = "${TUNE_FEATURES_tune-x86} i586-nlp"
+BASE_LIB_tune-i586-nlp-32 = "lib"
+TUNE_PKGARCH_tune-i586-nlp-32 = "i586-nlp-32"
+PACKAGE_EXTRA_ARCHS_tune-i586-nlp-32 = "i586-nlp-32"
Signature · 1 line
2.1.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 25 lines · Saul Wold

This tune file is needed to enable a GAS option specific to this cpu family in order to disable the usage of lock prefix instructions.

---
 meta/conf/machine/include/tune-i586-nlp.inc | 19 +++++++++++++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-i586-nlp.inc
meta/conf/machine/include/tune-i586-nlp.inc new file +9 -0
new file mode 100644
index 0000000..94e22c1
@@ -0,0 +1,19 @@
+# Settings for the GCC(1) cpu-type "quark":
+#
+#
+#
+DEFAULTTUNE ?= "i586-nlp-32"
+
+# Include the previous tune to pull in PACKAGE_EXTRA_ARCHS
+require conf/machine/include/x86/arch-x86.inc
+

meta/conf/machine/include/tune-i586-nlp.inc line 19

Quoted 10 lines
meta/conf/machine/include/tune-i586-nlp.inc new file +10 -0
+# x86 with no lock prefix
+TUNEVALID[i586-nlp] = "IA32 with Lock Prefix omitted"
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "i586-nlp", " -march=i586 -Wa,-momit-lock-prefix=yes", "", d)}"
+
+# Quark tune feature
+AVAILTUNES = "i586-nlp-32"
+TUNE_FEATURES_tune-i586-nlp-32 = "${TUNE_FEATURES_tune-x86} i586-nlp"
+BASE_LIB_tune-i586-nlp-32 = "lib"
+TUNE_PKGARCH_tune-i586-nlp-32 = "i586-nlp-32"
+PACKAGE_EXTRA_ARCHS_tune-i586-nlp-32 = "i586-nlp-32"

I believe this explicit assignment, instead of appending to tune-i586, addresses the issue Phil raised?

Signature · 2 lines
Darren Hart
Intel Open Source Technology Center
#2 lore raw
Quoted 10 lines · Darren Hart

meta/conf/machine/include/tune-i586-nlp.inc line 19

Quoted 7 lines
meta/conf/machine/include/tune-i586-nlp.inc new file +6 -0
+# Quark tune feature
+AVAILTUNES = "i586-nlp-32"
+TUNE_FEATURES_tune-i586-nlp-32 = "${TUNE_FEATURES_tune-x86} i586-nlp"
+BASE_LIB_tune-i586-nlp-32 = "lib"
+TUNE_PKGARCH_tune-i586-nlp-32 = "i586-nlp-32"
+PACKAGE_EXTRA_ARCHS_tune-i586-nlp-32 = "i586-nlp-32"

I believe this explicit assignment, instead of appending to tune-i586, addresses the issue Phil raised?

Correct, this looks much better and has been merged.

Cheers,

Richard