Skip to contentSkip to conversation

Patch "include/linux/sched.h: don't use task->pid/tgid in" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Jun 29, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    include/linux/sched.h: don't use task->pid/tgid in

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
include-linux-sched.h-don-t-use-task-pid-tgid-in.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From e1403b8edf669ff49bbdf602cc97fefa2760cb15 Mon Sep 17 00:00:00 2001

From: Oleg Nesterov <[email protected]>
Date: Wed, 11 Sep 2013 14:20:06 -0700
Subject: include/linux/sched.h: don't use task->pid/tgid in
same_thread_group/has_group_leader_pid

From: Oleg Nesterov <[email protected]>

commit e1403b8edf669ff49bbdf602cc97fefa2760cb15 upstream.

task_struct->pid/tgid should go away.

1. Change same_thread_group() to use task->signal for comparison.

2. Change has_group_leader_pid(task) to compare task_pid(task) with signal->leader_pid.

---
 include/linux/sched.h |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
include/linux/sched.h +4 -4
@@ -2203,15 +2203,15 @@ static inline bool thread_group_leader(s
  * all we care about is that we have a task with the appropriate
  * pid, we don't actually care if we have the right task.
  */
-static inline int has_group_leader_pid(struct task_struct *p)
+static inline bool has_group_leader_pid(struct task_struct *p)
 {
-	return p->pid == p->tgid;
+	return task_pid(p) == p->signal->leader_pid;
 }
 
 static inline
-int same_thread_group(struct task_struct *p1, struct task_struct *p2)
+bool same_thread_group(struct task_struct *p1, struct task_struct *p2)
 {
-	return p1->tgid == p2->tgid;
+	return p1->signal == p2->signal;
 }
 
 static inline struct task_struct *next_thread(const struct task_struct *p)

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/__ptrace_may_access-should-not-deny-sub-threads.patch queue-3.10/include-linux-sched.h-don-t-use-task-pid-tgid-in.patch queue-3.10/fput-turn-list_head-delayed_fput_list-into-llist_head.patch