Patch "Revert "crypto: talitos - convert to use be16_add_cpu()"" has been added to the 4.1-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
Revert "crypto: talitos - convert to use be16_add_cpu()"
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-crypto-talitos-convert-to-use-be16_add_cpu.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
69d9cd8c592f1abce820dbce7181bbbf6812cfbdMon Sep 17 00:00:00 2001
From: Horia Geant? <[email protected]>
Date: Mon, 11 May 2015 20:04:49 +0300
Subject: Revert "crypto: talitos - convert to use be16_add_cpu()"
From: Horia Geant? <[email protected]>
commit 69d9cd8c592f1abce820dbce7181bbbf6812cfbd upstream.
This reverts commit 7291a932c6e27d9768e374e9d648086636daf61c.
The conversion to be16_add_cpu() is incorrect in case cryptlen is negative due to premature (i.e. before addition / subtraction) implicit conversion of cryptlen (int -> u16) leading to sign loss.
--- drivers/crypto/talitos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/crypto/talitos.c +2 -1
@@ -925,7 +925,8 @@ static int sg_to_link_tbl(struct scatter sg_count--; link_tbl_ptr--; } -be16_add_cpu (&link_tbl_ptr->len, cryptlen); + link_tbl_ptr->len =cpu_to_be16 (be16_to_cpu (link_tbl_ptr->len) + + cryptlen);/* tag end of link table */ link_tbl_ptr->j_extent =DESC_PTR_LNKTBL_RETURN ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/crypto-talitos-avoid-memleak-in-talitos_alg_alloc.patch queue-4.1/revert-crypto-talitos-convert-to-use-be16_add_cpu.patch