Skip to contentSkip to conversation

Patch "ufs: Fix possible deadlock when looking up directories" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Jul 8, 2015 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ufs: Fix possible deadlock when looking up directories

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ufs-fix-possible-deadlock-when-looking-up-directories.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 514d748f69c97a51a2645eb198ac5c6218f22ff9 Mon Sep 17 00:00:00 2001

From: Jan Kara <[email protected]>
Date: Tue, 2 Jun 2015 11:26:34 +0200
Subject: ufs: Fix possible deadlock when looking up directories

From: Jan Kara <[email protected]>

commit 514d748f69c97a51a2645eb198ac5c6218f22ff9 upstream.

Commit e4502c63f56aeca88 (ufs: deal with nfsd/iget races) made ufs create inodes with I_NEW flag set. However ufs_mkdir() never cleared this flag. Thus if someone ever tried to lookup the directory by inode number, he would deadlock waiting for I_NEW to be cleared. Luckily this mostly happens only if the filesystem is exported over NFS since otherwise we have the inode attached to dentry and don't look it up by inode number. In rare cases dentry can get freed without inode being freed and then we'd hit the deadlock even without NFS export.

Fix the problem by clearing I_NEW before instantiating new directory inode.

Fixes e4502c63f56aeca887ced37f24e0def1ef11cec8
---
 fs/ufs/namei.c |    1 +
 1 file changed, 1 insertion(+)
fs/ufs/namei.c +1 -0
@@ -209,6 +209,7 @@ static int ufs_mkdir(struct inode * dir,
 		goto out_fail;
 	unlock_ufs(dir->i_sb);
 
+	unlock_new_inode(inode);
 	d_instantiate(dentry, inode);
 out:
 	return err;

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/ufs-fix-possible-deadlock-when-looking-up-directories.patch queue-3.10/ufs-fix-warning-from-unlock_new_inode.patch queue-3.10/fs-fix-s_nosec-handling.patch