Skip to contentSkip to conversation

Btrfs: remove unused mutex from struct 'btrfs_fs_info'

PATCH In review Byongho Lee 2 participants 2 messages Jul 10, 2015 Btrfs file system

lore
Share & tools
lore

Byongho Lee

author
#0 lore raw

PATCH 1/1 Btrfs: remove unused mutex from struct 'btrfs_fs_info'

The code using 'ordered_extent_flush_mutex' mutex has removed by below commit.
- 8d875f95da43c6a8f18f77869f2ef26e9594fecc
btrfs: disable strict file flushes for renames and truncates
But the mutex still lives in struct 'btrfs_fs_info'.

So, this patch removes the mutex from struct 'btrfs_fs_info' and its initialization code.

Signed-off-by Byongho Lee <[email protected]>
---
 fs/btrfs/ctree.h   | 6 ------
 fs/btrfs/disk-io.c | 1 -
 2 files changed, 7 deletions(-)
fs/btrfs/ctree.h +0 -6
index aac314e14188..cdde6d541b3a 100644
@@ -1518,12 +1518,6 @@ struct btrfs_fs_info {
 	 */
 	struct mutex ordered_operations_mutex;
 
-	/*
-	 * Same as ordered_operations_mutex except this is for ordered extents
-	 * and not the operations.
-	 */
-	struct mutex ordered_extent_flush_mutex;
-
 	struct rw_semaphore commit_root_sem;
 
 	struct rw_semaphore cleanup_work_sem;
fs/btrfs/disk-io.c +0 -1
index e5aad7f535aa..6ba584714c51 100644
@@ -2608,7 +2608,6 @@ int open_ctree(struct super_block *sb,
 
 
 	mutex_init(&fs_info->ordered_operations_mutex);
-	mutex_init(&fs_info->ordered_extent_flush_mutex);
 	mutex_init(&fs_info->tree_log_mutex);
 	mutex_init(&fs_info->chunk_mutex);
 	mutex_init(&fs_info->transaction_kthread_mutex);
Signature · 1 line
2.4.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Byongho Lee

The code using 'ordered_extent_flush_mutex' mutex has removed by below commit.
- 8d875f95da43c6a8f18f77869f2ef26e9594fecc
btrfs: disable strict file flushes for renames and truncates
But the mutex still lives in struct 'btrfs_fs_info'.

So, this patch removes the mutex from struct 'btrfs_fs_info' and its initialization code.

Signed-off-by Byongho Lee <[email protected]>
Reviewed-by David Sterba <[email protected]>