patch "USB: serial: Destroy serial_minors IDR on module exit" added to usb-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
USB: serial: Destroy serial_minors IDR on module exit
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
d23f47d4927fd2f61b3a754d83c7bcec215b5cfeMon Sep 17 00:00:00 2001
From: Johannes Thumshirn <[email protected]>
Date: Wed, 8 Jul 2015 17:26:37 +0200
Subject: USB: serial: Destroy serial_minors IDR on module exit
Destroy serial_minors IDR on module exit, reclaiming the allocated memory.
This was detected by the following semantic patch (written by Luis Rodriguez <[email protected]>)
<SmPL>
@ defines_module_init @
declarer name module_init, module_exit;
declarer name DEFINE_IDR;
identifier init;
@@
module_init(init);
@ defines_module_exit @
identifier exit;
@@
module_exit(exit);
@ declares_idr depends on defines_module_init && defines_module_exit @ identifier idr;
@@
DEFINE_IDR(idr);
@ on_exit_calls_destroy depends on declares_idr && defines_module_exit @ identifier declares_idr.idr, defines_module_exit.exit;
@@
exit(void)
{
...
idr_destroy(&idr);
...
}
@ missing_module_idr_destroy depends on declares_idr && defines_module_exit && !on_exit_calls_destroy @ identifier declares_idr.idr, defines_module_exit.exit;
@@
exit(void)
{
...
+idr_destroy(&idr);
}
</SmPL>
--- drivers/usb/serial/usb-serial.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/serial/usb-serial.c +1 -0
@@ -1306,6 +1306,7 @@ static void __exit usb_serial_exit(void)tty_unregister_driver (usb_serial_tty_driver);put_tty_driver (usb_serial_tty_driver);bus_unregister (&usb_serial_bus_type); +idr_destroy (&serial_minors); }
Signature · 1 line
2.4.5