rfkill-gpio: Add support for the Realtek 8723 BT
Subsystems (3)
PATCH 1/1 rfkill-gpio: Add support for the Realtek 8723 BT
http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/focu
s=127896
--- net/rfkill/rfkill-gpio.c | 1 + 1 file changed, 1 insertion(+)
net/rfkill/rfkill-gpio.c +0 -0
@@ -168,6 +168,7 @@ static const struct acpi_device_id
rfkill_acpi_match[] = {
{ "BCM2E3D", RFKILL_TYPE_BLUETOOTH },
{ "BCM2E40", RFKILL_TYPE_BLUETOOTH },
{ "BCM2E64", RFKILL_TYPE_BLUETOOTH },
+ { "OBDA8723", RFKILL_TYPE_BLUETOOTH },
{ "BCM4752", RFKILL_TYPE_GPS },
{ "LNV4752", RFKILL_TYPE_GPS },
{ },
Signature · 1 line
2.4.3
Quoted 4 lines · Bastien Nocera
http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/focu
s=127896Signed-off-by Bastien Nocera <[email protected]>
Bastien,
The subject of this patch needs a bit more detail. I know that you mean the RTL8723B versions of the Bluetooth devices. The subject should say this.
The commit message needs a bit more detail. Referencing the E-mail thread is OK, but a bit more is needed. What fails without this change?
To help keep that patches straight, change the next submission to say "[PATCH V2]" in the subject. In addition, after the ---, add a section saying what changed in V2. That info is not retained in the final commit message in the repo, but it can be very useful to a maintainer.
Larry
Quoted 19 lines
--- net/rfkill/rfkill-gpio.c | 1 + 1 file changed, 1 insertion(+)net/rfkill/rfkill-gpio.c +1
-0@@ -168,6 +168,7 @@ static const struct acpi_device_id rfkill_acpi_match[] = { { "BCM2E3D", RFKILL_TYPE_BLUETOOTH }, { "BCM2E40", RFKILL_TYPE_BLUETOOTH }, { "BCM2E64", RFKILL_TYPE_BLUETOOTH }, + { "OBDA8723", RFKILL_TYPE_BLUETOOTH }, { "BCM4752", RFKILL_TYPE_GPS }, { "LNV4752", RFKILL_TYPE_GPS },{ },
Johannes Berg
maintainerQuoted 18 lines · Larry Finger
Quoted 5 lines · Bastien Nocera
http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/
focu
s=127896Signed-off-by Bastien Nocera <[email protected]>Bastien,
The subject of this patch needs a bit more detail. I know that you mean the
RTL8723B versions of the Bluetooth devices. The subject should say this.The commit message needs a bit more detail. Referencing the E-mail thread is OK,
but a bit more is needed. What fails without this change?
Quoted 8 lines
To help keep that patches straight, change the next submission to say "[PATCH
V2]" in the subject. In addition, after the ---, add a section saying what
changed in V2. That info is not retained in the final commit message in the
repo, but it can be very useful to a maintainer.
And while at it, please use links that include the message-id (e.g. mid.gmane.org) so it's searchable even if the archive disappears.
johannes
Hi Bastien,
Quoted 21 lines
http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/focu
s=127896Signed-off-by Bastien Nocera <[email protected]>---
net/rfkill/rfkill-gpio.c| 1 +1 file changed, 1 insertion(+)net/rfkill/rfkill-gpio.c +1
-0@@ -168,6 +168,7 @@ static const struct acpi_device_id rfkill_acpi_match[] = { { "BCM2E3D", RFKILL_TYPE_BLUETOOTH }, { "BCM2E40", RFKILL_TYPE_BLUETOOTH }, { "BCM2E64", RFKILL_TYPE_BLUETOOTH }, + { "OBDA8723", RFKILL_TYPE_BLUETOOTH }, { "BCM4752", RFKILL_TYPE_GPS }, { "LNV4752", RFKILL_TYPE_GPS },
Quoted 1 line
{ },while this is most likely a good start to get people going and testing the hardware, I think long-term some these IDs have to move out of this driver and into a Realtek specific UART slave driver (once we get such a thing upstream).
I think one example would be what Fred is currently doing for the Broadcom UART devices. Essentially we are currently misusing the RFKILL switch for an on/off switch of the GPIO lines. This would be better handled by the Bluetooth subsystem itself when you power on the controller.
Regards
Marcel
Quoted 31 lines · Marcel Holtmann
Hi Bastien,
Quoted 22 lines
http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/
focu
s=127896Signed-off-by Bastien Nocera <[email protected]>---
net/rfkill/rfkill-gpio.c| 1 +1 file changed, 1 insertion(+)net/rfkill/rfkill-gpio.c +1
-0@@ -168,6 +168,7 @@ static const struct acpi_device_id rfkill_acpi_match[] = { { "BCM2E3D", RFKILL_TYPE_BLUETOOTH }, { "BCM2E40", RFKILL_TYPE_BLUETOOTH }, { "BCM2E64", RFKILL_TYPE_BLUETOOTH }, + { "OBDA8723", RFKILL_TYPE_BLUETOOTH }, { "BCM4752", RFKILL_TYPE_GPS }, { "LNV4752", RFKILL_TYPE_GPS },Quoted 1 line
{ },while this is most likely a good start to get people going and testing the hardware, I think long-term some these IDs have to move out of this driver and into a Realtek specific UART slave driver (once we get such a thing upstream).
Quoted 5 lines
I think one example would be what Fred is currently doing for the Broadcom UART devices. Essentially we are currently misusing the RFKILL switch for an on/off switch of the GPIO lines. This would be better handled by the Bluetooth subsystem itself when you power on the controller.
Duly noted. I'll postpone that until I have time to do hardware enablement on the Bluetooth side of that chipset.
Quoted 9 lines · Larry Finger
Quoted 5 lines · Bastien Nocera
http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/
focu
s=127896Signed-off-by Bastien Nocera <[email protected]>Bastien,
Quoted 8 lines
The subject of this patch needs a bit more detail. I know that you mean the
RTL8723B versions of the Bluetooth devices. The subject should say this.The commit message needs a bit more detail. Referencing the E-mail thread is OK,
but a bit more is needed. What fails without this change?
Nothing yet, as the current Bluetooth support for this device is completely in user-space, and doesn't sync up with rfkill.
Quoted 7 lines
To help keep that patches straight, change the next submission to say "[PATCH
V2]" in the subject. In addition, after the ---, add a section saying what
changed in V2. That info is not retained in the final commit message in the
repo, but it can be very useful to a maintainer.
I already submitted this patch? I certainly forgot doing so :)
Quoted 32 lines · Johannes Berg
Quoted 19 lines · Larry Finger
Quoted 6 lines · Bastien Nocera
http://thread.gmane.org/gmane.linux.kernel.wireless.general/12770
6/
focu
s=127896Signed-off-by Bastien Nocera <[email protected]>Bastien,
The subject of this patch needs a bit more detail. I know that you mean the
RTL8723B versions of the Bluetooth devices. The subject should say this.The commit message needs a bit more detail. Referencing the E-mail thread is OK,
but a bit more is needed. What fails without this change?Quoted 11 lines
To help keep that patches straight, change the next submission to say
"[PATCH
V2]" in the subject. In addition, after the ---, add a section saying
what
changed in V2. That info is not retained in the final commit message
in the
repo, but it can be very useful to a maintainer.
Quoted 2 lines
And while at it, please use links that include the message-id (e.g. mid.gmane.org) so it's searchable even if the archive disappears.
Didn't know that service, thanks.
Quoted 2 lines · Johannes Berg
And while at it, please use links that include the message-id (e.g. mid.gmane.org) so it's searchable even if the archive disappears.
BTW, I recently found out that kernel.org has a this type of service as well. From https://lkml.kernel.org/:
http://lkml.kernel.org/r/<message-id> - for marc.info links
http://lkml.kernel.org/g/<message-id> - for gmane.org links
Signature · 1 line
Kalle Valo