Skip to contentSkip to conversation

Security.c: fix 3 coding style indentation errors

PATCH In review Ahmed Mohamed Abd EL Mawgood 2 participants 2 messages Jul 16, 2015 Security (LSM)

lore
Share & tools
lore

Ahmed Mohamed Abd EL Mawgood

author
#0 lore raw

PATCH 1/1 Security.c: fix 3 coding style indentation errors

Quoted 1 line

From 34330e77b9dfec43e65de069e83ca41cc145ed07 Mon Sep 17 00:00:00 2001

From: ahmed <[email protected]>
Date: Thu, 16 Jul 2015 17:12:52 +0200
Subject: [PATCH] Security.c: fix 3 coding style indentation errors

This is my first patch to get my hand dirty
3 simple indentation errors fixing withen security/security.c

Signed-off-by Ahmed Mohamed <[email protected]>
---
 security/security.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
security/security.c +3 -3
index 595fffa..99c2d3b 100644
@@ -308,7 +308,7 @@ int security_sb_statfs(struct dentry *dentry)
 }
 
 int security_sb_mount(const char *dev_name, struct path *path,
-                       const char *type, unsigned long flags, void *data)
+			const char *type, unsigned long flags, void *data)
 {
 	return call_int_hook(sb_mount, 0, dev_name, path, type, flags, data);
 }

@@ -567,8 +567,8 @@ int security_inode_rename(struct inode *old_dir, struct dentry *old_dentry,
 			   struct inode *new_dir, struct dentry *new_dentry,
 			   unsigned int flags)
 {
-        if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
-            (d_is_positive(new_dentry) && IS_PRIVATE(d_backing_inode(new_dentry)))))
+	if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
+	(d_is_positive(new_dentry) && IS_PRIVATE(d_backing_inode(new_dentry)))))
 		return 0;
 
 	if (flags & RENAME_EXCHANGE) {
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Ahmed Mohamed Abd EL Mawgood

This is my first patch to get my hand dirty
3 simple indentation errors fixing withen security/security.c

[]

security/security.c

Quoted 1 line
security/security.c +0 -0

[]

security/security.c int security_inode_rename(struct inode *old_dir, struct dentry *old_dentry, · line 572

Quoted 9 lines
security/security.c +2 -2
@@ -567,8 +567,8 @@ int security_inode_rename(struct inode *old_dir, struct dentry *old_dentry,
 			   struct inode *new_dir, struct dentry *new_dentry,
 			   unsigned int flags)
 {
-        if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
-            (d_is_positive(new_dentry) && IS_PRIVATE(d_backing_inode(new_dentry)))))
+	if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
+	(d_is_positive(new_dentry) && IS_PRIVATE(d_backing_inode(new_dentry)))))
 		return 0;

See Documentation/CodingStyle, chapter 2:

Descendents are "substantially to the right", not aligned to the if

Some prefer alignment to open parentheses like:

	if (unlikely(IS_PRIVATE(d_backing_inode(old_dentry)) ||
		     (d_is_positive(new_dentry) &&
		      IS_PRIVATE(d_backing_inode(new_dentry)))))

Others just want the indentation on a tab stop.