Skip to contentSkip to conversation

Patch "gpio: crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip" has been added to the 4.0-stable tree

PATCH [email protected] 1 participant 1 message Jul 16, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

gpio: crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip

to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
gpio-crystalcove-set-irqchip_skip_set_wake-for-the-irqchip.patch
and it can be found in the queue-4.0 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 61e749d7e1627d375156553ea0ae83c4f6bb5a9b Mon Sep 17 00:00:00 2001

From: Aaron Lu <[email protected]>
Date: Thu, 28 May 2015 10:58:49 +0800
Subject: gpio: crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip

From: Aaron Lu <[email protected]>

commit 61e749d7e1627d375156553ea0ae83c4f6bb5a9b upstream.

The CrystalCove GPIO irqchip doesn't have irq_set_wake callback defined so we should set IRQCHIP_SKIP_SET_WAKE for it or it would cause an irq desc's wake_depth unbalanced warning during system resume phase from the gpio_keys driver, which is the driver for the power button of the ASUS T100 laptop.

---
 drivers/gpio/gpio-crystalcove.c |    1 +
 1 file changed, 1 insertion(+)
drivers/gpio/gpio-crystalcove.c +1 -0
@@ -250,6 +250,7 @@ static struct irq_chip crystalcove_irqch
 	.irq_set_type		= crystalcove_irq_type,
 	.irq_bus_lock		= crystalcove_bus_lock,
 	.irq_bus_sync_unlock	= crystalcove_bus_sync_unlock,
+	.flags			= IRQCHIP_SKIP_SET_WAKE,
 };
 
 static irqreturn_t crystalcove_gpio_irq_handler(int irq, void *data)

Patches currently in stable-queue which might be from [email protected] are

queue-4.0/gpio-crystalcove-set-irqchip_skip_set_wake-for-the-irqchip.patch