drm/i915: fix checksum write for automated test reply
Subsystems (2)
PATCH 1/1 drm/i915: fix checksum write for automated test reply
From: "Thulasimani,Sivakumar" <[email protected]>
DP spec requires the checksum of the last block read to be written when replying to TEST_EDID_READ. This patch fixes the current code to do the same.
--- drivers/gpu/drm/i915/intel_dp.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dp.c +8 -1
@@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp) intel_dp->aux.i2c_defer_count); intel_dp->compliance_test_data =INTEL_DP_RESOLUTION_FAILSAFE ; }else { +struct edid *block = intel_connector->detect_edid; + +/* We have to write the checksum +* of the last block read +*/ + block += intel_connector->detect_edid->extensions; +if (!drm_dp_dpcd_write (&intel_dp->aux,DP_TEST_EDID_CHECKSUM , - &intel_connector->detect_edid->checksum, + &block->checksum,1 ))DRM_DEBUG_KMS ("Failed to write EDID checksum\n" );
Signature · 6 lines
1.7.9.5 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Task id: 6848 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
ILK 295/295 295/295 SNB 315/315 315/315 IVB 342/342 342/342 BYT 285/285 285/285 HSW 378/380 378/380
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Any comments for this change ?
Quoted 33 lines · Sivakumar Thulasimani
From: "Thulasimani,Sivakumar" <[email protected]>
DP spec requires the checksum of the last block read to be written when replying to
TEST_EDID_READ. This patch fixes the current code to do the same.Signed-off-by Sivakumar Thulasimani <[email protected]>--- drivers/gpu/drm/i915/intel_dp.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/intel_dp.c +8
-1@@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp) intel_dp->aux.i2c_defer_count); intel_dp->compliance_test_data =INTEL_DP_RESOLUTION_FAILSAFE ; }else { +struct edid *block = intel_connector->detect_edid; + +/* We have to write the checksum +* of the last block read +*/ + block += intel_connector->detect_edid->extensions; +if (!drm_dp_dpcd_write (&intel_dp->aux,DP_TEST_EDID_CHECKSUM , - &intel_connector->detect_edid->checksum, + &block->checksum,1 ))DRM_DEBUG_KMS ("Failed to write EDID checksum\n" );
Signature · 7 lines
regards, Sivakumar _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx