f2fs: call set_page_dirty to attach i_wb for cgroup
Subsystems (2)
Jaegeuk Kim
maintainerPATCH 1/2 f2fs: call set_page_dirty to attach i_wb for cgroup
The cgroup attaches inode->i_wb via mark_inode_dirty and when set_page_writeback is called, __inc_wb_stat() updates i_wb's stat.
So, we need to explicitly call set_page_dirty->__mark_inode_dirty in prior to any writebacking pages.
This patch should resolve the following kernel panic reported by Andreas Reis.
https://bugzilla.kernel.org/show_bug.cgi?id=101801
--- Comment #2 from Andreas Reis <[email protected]> ---
BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8 IP: [<ffffffff8149deea>] __percpu_counter_add+0x1a/0x90 PGD 2951ff067 PUD 2df43f067 PMD 0 Oops: 0000 [#1] PREEMPT SMP Modules linked in: CPU: 7 PID: 10356 Comm: gcc Tainted: G W 4.2.0-1-cu #1 Hardware name: Gigabyte Technology Co., Ltd. G1.Sniper M5/G1.Sniper M5, BIOS T01 02/03/2015 task: ffff880295044f80 ti: ffff880295140000 task.ti: ffff880295140000 RIP: 0010:[<ffffffff8149deea>] [<ffffffff8149deea>] __percpu_counter_add+0x1a/0x90 RSP: 0018:ffff880295143ac8 EFLAGS: 00010082 RAX: 0000000000000003 RBX: ffffea000a526d40 RCX: 0000000000000001 RDX: 0000000000000020 RSI: 0000000000000001 RDI: 0000000000000088 RBP: ffff880295143ae8 R08: 0000000000000000 R09: ffff88008f69bb30 R10: 00000000fffffffa R11: 0000000000000000 R12: 0000000000000088 R13: 0000000000000001 R14: ffff88041d099000 R15: ffff880084a205d0 FS: 00007f8549374700(0000) GS:ffff88042f3c0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000000a8 CR3: 000000033e1d5000 CR4: 00000000001406e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Stack: 0000000000000000 ffffea000a526d40 ffff880084a20738 ffff880084a20750 ffff880295143b48 ffffffff811cc91e ffff880000000000 0000000000000296 0000000000000000 ffff880417090198 0000000000000000 ffffea000a526d40 Call Trace: [<ffffffff811cc91e>] __test_set_page_writeback+0xde/0x1d0 [<ffffffff813fee87>] do_write_data_page+0xe7/0x3a0 [<ffffffff813faeea>] gc_data_segment+0x5aa/0x640 [<ffffffff813fb0b8>] do_garbage_collect+0x138/0x150 [<ffffffff813fb3fe>] f2fs_gc+0x1be/0x3e0 [<ffffffff81405541>] f2fs_balance_fs+0x81/0x90 [<ffffffff813ee357>] f2fs_unlink+0x47/0x1d0 [<ffffffff81239329>] vfs_unlink+0x109/0x1b0 [<ffffffff8123e3d7>] do_unlinkat+0x287/0x2c0 [<ffffffff8123ebc6>] SyS_unlink+0x16/0x20 [<ffffffff81942e2e>] entry_SYSCALL_64_fastpath+0x12/0x71 Code: 41 5e 5d c3 0f 1f 00 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 41 55 49
89 f5 41 54 49 89 fc 53 48 83 ec 08 65 ff 05 e6 d9 b6 7e <48> 8b 47 20 48 63 ca 65 8b 18 48 63 db 48 01 f3 48 39 cb 7d 0a
RIP [<ffffffff8149deea>] __percpu_counter_add+0x1a/0x90
RSP <ffff880295143ac8>
CR2: 00000000000000a8
---[ end trace 5132449a58ed93a3 ]---
note: gcc[10356] exited with preempt_count 2
--- fs/f2fs/data.c | 2 -- fs/f2fs/file.c | 7 ++++--- fs/f2fs/gc.c | 7 ++++++- fs/f2fs/inline.c | 2 ++ fs/f2fs/segment.c | 1 + 5 files changed, 13 insertions(+), 6 deletions(-)
fs/f2fs/data.c +0 -2
@@ -1573,8 +1573,6 @@ static int f2fs_set_data_page_dirty(struct page *page)return 1 ; } -mark_inode_dirty (inode); -if (!PageDirty (page)) {__set_page_dirty_nobuffers (page);update_dirty_page (inode, page);
fs/f2fs/file.c +4 -3
@@ -1356,12 +1356,13 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)if (ret)return ret; -if (f2fs_is_atomic_file (inode)) +if (f2fs_is_atomic_file (inode)) { +clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE );commit_inmem_pages (inode, false); + } ret =f2fs_sync_file (filp,0 ,LLONG_MAX ,0 );mnt_drop_write_file (filp); -clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE );return ret; }
@@ -1416,8 +1417,8 @@ static int f2fs_ioc_abort_volatile_write(struct file *filp)f2fs_balance_fs (F2FS_I_SB (inode));if (f2fs_is_atomic_file (inode)) { -commit_inmem_pages (inode, false);clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE ); +commit_inmem_pages (inode, false); }if (f2fs_is_volatile_file (inode))
fs/f2fs/gc.c +6 -1
@@ -571,6 +571,11 @@ static void move_encrypted_block(struct inode *inode, block_t bidx)if (unlikely (fio.encrypted_page->mapping !=META_MAPPING (fio.sbi))) goto put_page_out; +set_page_dirty (fio.encrypted_page); +f2fs_wait_on_page_writeback (fio.encrypted_page,META ); +if (clear_page_dirty_for_io (fio.encrypted_page)) +dec_page_count (fio.sbi,F2FS_DIRTY_META ); +set_page_writeback (fio.encrypted_page);/* allocate block address */
@@ -615,8 +620,8 @@ static void move_data_page(struct inode *inode, block_t bidx, int gc_type) .page = page, .encrypted_page = NULL, }; +set_page_dirty (page);f2fs_wait_on_page_writeback (page,DATA ); -if (clear_page_dirty_for_io (page))inode_dec_dirty_pages (inode);set_cold_data (page);
fs/f2fs/inline.c +2 -0
@@ -141,6 +141,8 @@ int f2fs_convert_inline_page(struct dnode_of_data *dn, struct page *page)kunmap_atomic (dst_addr);SetPageUptodate (page); no_update: +set_page_dirty (page); +/* clear dirty state */ dirty =clear_page_dirty_for_io (page);
fs/f2fs/segment.c +1 -0
@@ -257,6 +257,7 @@ void commit_inmem_pages(struct inode *inode, bool abort)if (!abort) {lock_page (cur->page);if (cur->page->mapping == inode->i_mapping) { +set_page_dirty (cur->page);f2fs_wait_on_page_writeback (cur->page,DATA );if (clear_page_dirty_for_io (cur->page))inode_dec_dirty_pages (inode);
Signature · 1 line
2.1.1
Jaegeuk Kim
maintainerPATCH 2/2 f2fs: handle error cases in commit_inmem_pages
This patch adds to handle error cases in commit_inmem_pages. If an error occurs, it stops to write the pages and return the error right away.
--- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 6 ++++-- fs/f2fs/segment.c | 10 ++++++++-- 3 files changed, 13 insertions(+), 5 deletions(-)
fs/f2fs/f2fs.h +1 -1
@@ -1697,7 +1697,7 @@ void destroy_node_manager_caches(void);* segment.c */ void register_inmem_page (struct inode *,struct page *); -void commit_inmem_pages (struct inode *,bool ); +int commit_inmem_pages (struct inode *,bool );void f2fs_balance_fs (struct f2fs_sb_info *);void f2fs_balance_fs_bg (struct f2fs_sb_info *);int f2fs_issue_flush (struct f2fs_sb_info *);
fs/f2fs/file.c +4 -2
@@ -1358,7 +1358,9 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)if (f2fs_is_atomic_file (inode)) {clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE ); -commit_inmem_pages (inode, false); + ret =commit_inmem_pages (inode, false); +if (ret) +return ret; } ret =f2fs_sync_file (filp,0 ,LLONG_MAX ,0 );
@@ -1418,7 +1420,7 @@ static int f2fs_ioc_abort_volatile_write(struct file *filp)if (f2fs_is_atomic_file (inode)) {clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE ); -commit_inmem_pages (inode, false); +commit_inmem_pages (inode, true); }if (f2fs_is_volatile_file (inode))
fs/f2fs/segment.c +8 -2
@@ -227,7 +227,7 @@ retry:trace_f2fs_register_inmem_page (page,INMEM ); } -void commit_inmem_pages (struct inode *inode,bool abort) +int commit_inmem_pages (struct inode *inode,bool abort) {struct f2fs_sb_info *sbi =F2FS_I_SB (inode);struct f2fs_inode_info *fi =F2FS_I (inode);
@@ -239,6 +239,7 @@ void commit_inmem_pages(struct inode *inode, bool abort) .rw = WRITE_SYNC | REQ_PRIO, .encrypted_page = NULL, }; +int err =0 ;/* * The abort is true only when f2fs_evict_inode is called.
@@ -263,8 +264,12 @@ void commit_inmem_pages(struct inode *inode, bool abort)inode_dec_dirty_pages (inode);trace_f2fs_commit_inmem_page (cur->page,INMEM ); fio.page = cur->page; -do_write_data_page (&fio); + err =do_write_data_page (&fio); submit_bio = true; +if (err) { +unlock_page (cur->page); +break ; + } }f2fs_put_page (cur->page,1 ); }else {
@@ -283,6 +288,7 @@ void commit_inmem_pages(struct inode *inode, bool abort)if (submit_bio)f2fs_submit_merged_bio (sbi,DATA ,WRITE ); } +return err; }/*
Signature · 1 line
2.1.1
RE: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases in commit_inmem_pages
Hi Jaegeuk,
Quoted 78 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Sunday, July 26, 2015 8:21 AM
To: [email protected]; [email protected]; [email protected]
Cc: Jaegeuk Kim
Subject: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases incommit_inmem_pagesThis patch adds to handle error cases in
commit_inmem_pages. If an error occurs, it stops to write the pages and return the error right away.Signed-off-by Jaegeuk Kim <[email protected]>--- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 6 ++++-- fs/f2fs/segment.c | 10 ++++++++-- 3 files changed, 13 insertions(+), 5 deletions(-)fs/f2fs/f2fs.h +1
-1@@ -1697,7 +1697,7 @@ void destroy_node_manager_caches(void);* segment.c */ void register_inmem_page (struct inode *,struct page *); -void commit_inmem_pages (struct inode *,bool ); +int commit_inmem_pages (struct inode *,bool );void f2fs_balance_fs (struct f2fs_sb_info *);void f2fs_balance_fs_bg (struct f2fs_sb_info *);int f2fs_issue_flush (struct f2fs_sb_info *);fs/f2fs/file.c +4
-2@@ -1358,7 +1358,9 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)if (f2fs_is_atomic_file (inode)) {clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE ); -commit_inmem_pages (inode, false); + ret =commit_inmem_pages (inode, false); +if (ret) +return ret; } ret =f2fs_sync_file (filp,0 ,LLONG_MAX ,0 );@@ -1418,7 +1420,7 @@ static int f2fs_ioc_abort_volatile_write(struct file *filp)if (f2fs_is_atomic_file (inode)) {clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE ); -commit_inmem_pages (inode, false); +commit_inmem_pages (inode, true); }if (f2fs_is_volatile_file (inode))fs/f2fs/segment.c +2
-1@@ -227,7 +227,7 @@ retry:trace_f2fs_register_inmem_page (page,INMEM ); } -void commit_inmem_pages (struct inode *inode,bool abort) +int commit_inmem_pages (struct inode *inode,bool abort) {struct f2fs_sb_info *sbi =F2FS_I_SB (inode);struct f2fs_inode_info *fi =F2FS_I (inode);@@ -239,6 +239,7 @@ void commit_inmem_pages(struct inode *inode, bool abort) .rw = WRITE_SYNC | REQ_PRIO, .encrypted_page = NULL, }; +int err =0 ;/* * The abort is true only when f2fs_evict_inode is called.
fs/f2fs/segment.c void commit_inmem_pages(struct inode *inode, bool abort) · line 270
Quoted 8 lines
fs/f2fs/segment.c +3
-1@@ -263,8 +264,12 @@ void commit_inmem_pages(struct inode *inode, bool abort)inode_dec_dirty_pages (inode);trace_f2fs_commit_inmem_page (cur->page,INMEM ); fio.page = cur->page; -do_write_data_page (&fio); + err =do_write_data_page (&fio); submit_bio = true; +if (err) { +unlock_page (cur->page);
Shouldn't we invoke f2fs_put_page(,1) here?
Quoted 17 lines
fs/f2fs/segment.c +3
-1+break ; + } }f2fs_put_page (cur->page,1 ); }else {@@ -283,6 +288,7 @@ void commit_inmem_pages(struct inode *inode, bool abort)if (submit_bio)f2fs_submit_merged_bio (sbi,DATA ,WRITE ); } +return err; }/* -- 2.1.1
Quoted 5 lines
------------------------------------------------------------------------------
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
------------------------------------------------------------------------------
Jaegeuk Kim
maintainerRe: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases in commit_inmem_pages
Quoted 77 lines · Chao Yu
Hi Jaegeuk,
Quoted 75 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Sunday, July 26, 2015 8:21 AM
To: [email protected]; [email protected]; [email protected]
Cc: Jaegeuk Kim
Subject: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases incommit_inmem_pagesThis patch adds to handle error cases in
commit_inmem_pages. If an error occurs, it stops to write the pages and return the error right away.Signed-off-by Jaegeuk Kim <[email protected]>--- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 6 ++++-- fs/f2fs/segment.c | 10 ++++++++-- 3 files changed, 13 insertions(+), 5 deletions(-)fs/f2fs/f2fs.h +1
-1@@ -1697,7 +1697,7 @@ void destroy_node_manager_caches(void);* segment.c */ void register_inmem_page (struct inode *,struct page *); -void commit_inmem_pages (struct inode *,bool ); +int commit_inmem_pages (struct inode *,bool );void f2fs_balance_fs (struct f2fs_sb_info *);void f2fs_balance_fs_bg (struct f2fs_sb_info *);int f2fs_issue_flush (struct f2fs_sb_info *);fs/f2fs/file.c +4
-2@@ -1358,7 +1358,9 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)if (f2fs_is_atomic_file (inode)) {clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE ); -commit_inmem_pages (inode, false); + ret =commit_inmem_pages (inode, false); +if (ret) +return ret; } ret =f2fs_sync_file (filp,0 ,LLONG_MAX ,0 );@@ -1418,7 +1420,7 @@ static int f2fs_ioc_abort_volatile_write(struct file *filp)if (f2fs_is_atomic_file (inode)) {clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE ); -commit_inmem_pages (inode, false); +commit_inmem_pages (inode, true); }if (f2fs_is_volatile_file (inode))fs/f2fs/segment.c +2
-1@@ -227,7 +227,7 @@ retry:trace_f2fs_register_inmem_page (page,INMEM ); } -void commit_inmem_pages (struct inode *inode,bool abort) +int commit_inmem_pages (struct inode *inode,bool abort) {struct f2fs_sb_info *sbi =F2FS_I_SB (inode);struct f2fs_inode_info *fi =F2FS_I (inode);@@ -239,6 +239,7 @@ void commit_inmem_pages(struct inode *inode, bool abort) .rw = WRITE_SYNC | REQ_PRIO, .encrypted_page = NULL, }; +int err =0 ;
Quoted 13 lines
fs/f2fs/segment.c void commit_inmem_pages(struct inode *inode, bool abort) · line 270
Quoted 11 lines
fs/f2fs/segment.c +3
-1/* * The abort is true only when f2fs_evict_inode is called. @@ -263,8 +264,12 @@ void commit_inmem_pages(struct inode *inode, bool abort)inode_dec_dirty_pages (inode);trace_f2fs_commit_inmem_page (cur->page,INMEM ); fio.page = cur->page; -do_write_data_page (&fio); + err =do_write_data_page (&fio); submit_bio = true; +if (err) { +unlock_page (cur->page);Shouldn't we invoke
f2fs_put_page(,1)here?
This entry is not removed from the list.
So, after failure, the abort path will put the page and remove it from the list.
Thanks,
Quoted 18 lines
Quoted 18 lines
fs/f2fs/segment.c +3
-1+break ; + } }f2fs_put_page (cur->page,1 ); }else {@@ -283,6 +288,7 @@ void commit_inmem_pages(struct inode *inode, bool abort)if (submit_bio)f2fs_submit_merged_bio (sbi,DATA ,WRITE ); } +return err; }/* -- 2.1.1
Quoted 5 lines
Quoted 5 lines
------------------------------------------------------------------------------
_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
------------------------------------------------------------------------------
RE: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases in commit_inmem_pages
Hi Jaegeuk,
Quoted 49 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Tuesday, July 28, 2015 11:57 PM
To: Chao Yu
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases incommit_inmem_pagesQuoted 40 lines · Chao Yu
Hi Jaegeuk,
Quoted 38 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Sunday, July 26, 2015 8:21 AM
To: [email protected]; [email protected]; [email protected]
Cc: Jaegeuk Kim
Subject: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases incommit_inmem_pagesThis patch adds to handle error cases in
commit_inmem_pages. If an error occurs, it stops to write the pages and return the error right away.Signed-off-by Jaegeuk Kim <[email protected]>--- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 6 ++++-- fs/f2fs/segment.c | 10 ++++++++-- 3 files changed, 13 insertions(+), 5 deletions(-)fs/f2fs/f2fs.h +1
-1@@ -1697,7 +1697,7 @@ void destroy_node_manager_caches(void);* segment.c */ void register_inmem_page (struct inode *,struct page *); -void commit_inmem_pages (struct inode *,bool ); +int commit_inmem_pages (struct inode *,bool );void f2fs_balance_fs (struct f2fs_sb_info *);void f2fs_balance_fs_bg (struct f2fs_sb_info *);int f2fs_issue_flush (struct f2fs_sb_info *);fs/f2fs/file.c +0
-0@@ -1358,7 +1358,9 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)
Quoted 6 lines
Quoted 6 lines
fs/f2fs/file.c static int f2fs_ioc_commit_atomic_write(struct file *filp) · line 1363
Quoted 6 lines
fs/f2fs/file.c +3
-1if (f2fs_is_atomic_file (inode)) {clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE ); -commit_inmem_pages (inode, false); + ret =commit_inmem_pages (inode, false); +if (ret) +return ret;
It looks we forget to call mnt_drop_write_file before return.
[snip]
Quoted 2 lines
This entry is not removed from the list.
So, after failure, the abort path will put the page and remove it from the list.
Oh, you're right, thanks for your explanation! :)
Thanks,
Jaegeuk Kim
maintainerRe: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases in commit_inmem_pages
Quoted 51 lines · Chao Yu
Hi Jaegeuk,
Quoted 49 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Tuesday, July 28, 2015 11:57 PM
To: Chao Yu
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases incommit_inmem_pagesQuoted 40 lines · Chao Yu
Hi Jaegeuk,
Quoted 38 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Sunday, July 26, 2015 8:21 AM
To: [email protected]; [email protected]; [email protected]
Cc: Jaegeuk Kim
Subject: [f2fs-dev] [PATCH 2/2] f2fs: handle error cases incommit_inmem_pagesThis patch adds to handle error cases in
commit_inmem_pages. If an error occurs, it stops to write the pages and return the error right away.Signed-off-by Jaegeuk Kim <[email protected]>--- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 6 ++++-- fs/f2fs/segment.c | 10 ++++++++-- 3 files changed, 13 insertions(+), 5 deletions(-)fs/f2fs/f2fs.h +1
-1@@ -1697,7 +1697,7 @@ void destroy_node_manager_caches(void);* segment.c */ void register_inmem_page (struct inode *,struct page *); -void commit_inmem_pages (struct inode *,bool ); +int commit_inmem_pages (struct inode *,bool );void f2fs_balance_fs (struct f2fs_sb_info *);void f2fs_balance_fs_bg (struct f2fs_sb_info *);int f2fs_issue_flush (struct f2fs_sb_info *);fs/f2fs/file.c +0
-0@@ -1358,7 +1358,9 @@ static int f2fs_ioc_commit_atomic_write(struct file *filp)
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
fs/f2fs/file.c static int f2fs_ioc_commit_atomic_write(struct file *filp) · line 1363
Quoted 6 lines
fs/f2fs/file.c +3
-1if (f2fs_is_atomic_file (inode)) {clear_inode_flag (F2FS_I (inode),FI_ATOMIC_FILE ); -commit_inmem_pages (inode, false); + ret =commit_inmem_pages (inode, false); +if (ret) +return ret;It looks we forget to call
mnt_drop_write_filebefore return.
Oh, yes. :)
I fixed that.
Thanks,
Quoted 9 lines
[snip]
Quoted 2 lines
This entry is not removed from the list.
So, after failure, the abort path will put the page and remove it from the list.Oh, you're right, thanks for your explanation! :)
Thanks,
Hi Jaegeuk,
Quoted 63 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Sunday, July 26, 2015 8:21 AM
To: [email protected]; [email protected]; [email protected]
Cc: Jaegeuk Kim
Subject: [f2fs-dev] [PATCH 1/2] f2fs: callset_page_dirtyto attachi_wbfor cgroupThe cgroup attaches
inode->i_wbviamark_inode_dirtyand whenset_page_writebackis called,__inc_wb_stat()updates i_wb's stat.So, we need to explicitly call
set_page_dirty->__mark_inode_dirtyin prior to any writebacking pages.This patch should resolve the following kernel panic reported by Andreas Reis.
https://bugzilla.kernel.org/show_bug.cgi?id=101801
--- Comment #2 from Andreas Reis <[email protected]> ---
BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8 IP: [<ffffffff8149deea>] __percpu_counter_add+0x1a/0x90 PGD 2951ff067 PUD 2df43f067 PMD 0 Oops: 0000 [#1] PREEMPT SMP Modules linked in: CPU: 7 PID: 10356 Comm: gcc Tainted: G W 4.2.0-1-cu #1 Hardware name: Gigabyte Technology Co., Ltd. G1.Sniper M5/G1.Sniper M5, BIOS T01 02/03/2015 task: ffff880295044f80 ti: ffff880295140000 task.ti: ffff880295140000 RIP: 0010:[<ffffffff8149deea>] [<ffffffff8149deea>] __percpu_counter_add+0x1a/0x90 RSP: 0018:ffff880295143ac8 EFLAGS: 00010082 RAX: 0000000000000003 RBX: ffffea000a526d40 RCX: 0000000000000001 RDX: 0000000000000020 RSI: 0000000000000001 RDI: 0000000000000088 RBP: ffff880295143ae8 R08: 0000000000000000 R09: ffff88008f69bb30 R10: 00000000fffffffa R11: 0000000000000000 R12: 0000000000000088 R13: 0000000000000001 R14: ffff88041d099000 R15: ffff880084a205d0 FS: 00007f8549374700(0000) GS:ffff88042f3c0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000000a8 CR3: 000000033e1d5000 CR4: 00000000001406e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Stack: 0000000000000000 ffffea000a526d40 ffff880084a20738 ffff880084a20750 ffff880295143b48 ffffffff811cc91e ffff880000000000 0000000000000296 0000000000000000 ffff880417090198 0000000000000000 ffffea000a526d40 Call Trace: [<ffffffff811cc91e>] __test_set_page_writeback+0xde/0x1d0 [<ffffffff813fee87>] do_write_data_page+0xe7/0x3a0 [<ffffffff813faeea>] gc_data_segment+0x5aa/0x640 [<ffffffff813fb0b8>] do_garbage_collect+0x138/0x150 [<ffffffff813fb3fe>] f2fs_gc+0x1be/0x3e0 [<ffffffff81405541>] f2fs_balance_fs+0x81/0x90 [<ffffffff813ee357>] f2fs_unlink+0x47/0x1d0 [<ffffffff81239329>] vfs_unlink+0x109/0x1b0 [<ffffffff8123e3d7>] do_unlinkat+0x287/0x2c0 [<ffffffff8123ebc6>] SyS_unlink+0x16/0x20 [<ffffffff81942e2e>] entry_SYSCALL_64_fastpath+0x12/0x71 Code: 41 5e 5d c3 0f 1f 00 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 41 55 4989 f5 41 54 49 89 fc 53 48 83 ec 08 65 ff 05 e6 d9 b6 7e <48> 8b 47 20 48 63 ca 65 8b 18 48 63 db 48 01 f3 48 39 cb 7d 0a
RIP [<ffffffff8149deea>]__percpu_counter_add+0x1a/0x90
RSP <ffff880295143ac8>
CR2:00000000000000a8
Quoted 4 lines
---[ end trace 5132449a58ed93a3 ]---note: gcc[10356] exited with
preempt_count2Signed-off-by Jaegeuk Kim <[email protected]>
Good catch!
BTW, is this commit facd126d961d ("f2fs: fix wrong f2fs_put_page call for an error case") be submitted incorrectly? it seems not a good fix.
Thanks,
------------------------------------------------------------------------------
Jaegeuk Kim
maintainerQuoted 68 lines · Chao Yu
Hi Jaegeuk,
Quoted 66 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Sunday, July 26, 2015 8:21 AM
To: [email protected]; [email protected]; [email protected]
Cc: Jaegeuk Kim
Subject: [f2fs-dev] [PATCH 1/2] f2fs: callset_page_dirtyto attachi_wbfor cgroupThe cgroup attaches
inode->i_wbviamark_inode_dirtyand whenset_page_writebackis called,__inc_wb_stat()updates i_wb's stat.So, we need to explicitly call
set_page_dirty->__mark_inode_dirtyin prior to any writebacking pages.This patch should resolve the following kernel panic reported by Andreas Reis.
https://bugzilla.kernel.org/show_bug.cgi?id=101801
--- Comment #2 from Andreas Reis <[email protected]> ---
BUG: unable to handle kernel NULL pointer dereference at 00000000000000a8 IP: [<ffffffff8149deea>] __percpu_counter_add+0x1a/0x90 PGD 2951ff067 PUD 2df43f067 PMD 0 Oops: 0000 [#1] PREEMPT SMP Modules linked in: CPU: 7 PID: 10356 Comm: gcc Tainted: G W 4.2.0-1-cu #1 Hardware name: Gigabyte Technology Co., Ltd. G1.Sniper M5/G1.Sniper M5, BIOS T01 02/03/2015 task: ffff880295044f80 ti: ffff880295140000 task.ti: ffff880295140000 RIP: 0010:[<ffffffff8149deea>] [<ffffffff8149deea>] __percpu_counter_add+0x1a/0x90 RSP: 0018:ffff880295143ac8 EFLAGS: 00010082 RAX: 0000000000000003 RBX: ffffea000a526d40 RCX: 0000000000000001 RDX: 0000000000000020 RSI: 0000000000000001 RDI: 0000000000000088 RBP: ffff880295143ae8 R08: 0000000000000000 R09: ffff88008f69bb30 R10: 00000000fffffffa R11: 0000000000000000 R12: 0000000000000088 R13: 0000000000000001 R14: ffff88041d099000 R15: ffff880084a205d0 FS: 00007f8549374700(0000) GS:ffff88042f3c0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000000000a8 CR3: 000000033e1d5000 CR4: 00000000001406e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Stack: 0000000000000000 ffffea000a526d40 ffff880084a20738 ffff880084a20750 ffff880295143b48 ffffffff811cc91e ffff880000000000 0000000000000296 0000000000000000 ffff880417090198 0000000000000000 ffffea000a526d40 Call Trace: [<ffffffff811cc91e>] __test_set_page_writeback+0xde/0x1d0 [<ffffffff813fee87>] do_write_data_page+0xe7/0x3a0 [<ffffffff813faeea>] gc_data_segment+0x5aa/0x640 [<ffffffff813fb0b8>] do_garbage_collect+0x138/0x150 [<ffffffff813fb3fe>] f2fs_gc+0x1be/0x3e0 [<ffffffff81405541>] f2fs_balance_fs+0x81/0x90 [<ffffffff813ee357>] f2fs_unlink+0x47/0x1d0 [<ffffffff81239329>] vfs_unlink+0x109/0x1b0 [<ffffffff8123e3d7>] do_unlinkat+0x287/0x2c0 [<ffffffff8123ebc6>] SyS_unlink+0x16/0x20 [<ffffffff81942e2e>] entry_SYSCALL_64_fastpath+0x12/0x71 Code: 41 5e 5d c3 0f 1f 00 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 41 55 4989 f5 41 54 49 89 fc 53 48 83 ec 08 65 ff 05 e6 d9 b6 7e <48> 8b 47 20 48 63 ca 65 8b 18 48 63 db 48 01 f3 48 39 cb 7d 0a
RIP [<ffffffff8149deea>]__percpu_counter_add+0x1a/0x90
RSP <ffff880295143ac8>
CR2:00000000000000a8---[ end trace 5132449a58ed93a3 ]---note: gcc[10356] exited with
preempt_count2
Quoted 5 lines
Quoted 1 line
Signed-off-by Jaegeuk Kim <[email protected]>Good catch!
Reviewed-by Chao Yu <[email protected]>
Oh, I've already requested for merge.
Quoted 3 lines
BTW, is this commit
facd126d961d("f2fs: fix wrongf2fs_put_pagecall for an error case") be submitted incorrectly? it seems not a good fix.
Oh, what is that? I was out of mind.
Thank you for pointing that out. :)
Quoted 2 lines
Thanks,