leds: tlc591xx: Remove redundant I2C_FUNC_SMBUS_BYTE_DATA functionality check
PATCH 1/1 leds: tlc591xx: Remove redundant I2C_FUNC_SMBUS_BYTE_DATA functionality check
This checking is done by regmap_get_i2c_bus() which is called in devm_regmap_init_i2c().
Signed-off-by Axel Lin <[email protected]>
--- drivers/leds/leds-tlc591xx.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/leds/leds-tlc591xx.c +0 -4
@@ -231,10 +231,6 @@ tlc591xx_probe(struct i2c_client *client,if (!count || count > tlc591xx->max_leds)return -EINVAL ; -if (!i2c_check_functionality (client->adapter, -I2C_FUNC_SMBUS_BYTE_DATA )) -return -EIO ; - priv =devm_kzalloc (dev,sizeof (*priv),GFP_KERNEL );if (!priv)return -ENOMEM ;
Signature · 1 line
2.1.0
Quoted 4 lines · Axel Lin
This checking is done by
regmap_get_i2c_bus()which is called indevm_regmap_init_i2c().Signed-off-by Axel Lin <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>
Thanks
Andrew
Quoted 24 lines
--- drivers/leds/leds-tlc591xx.c | 4 ---- 1 file changed, 4 deletions(-)drivers/leds/leds-tlc591xx.c +0
-4@@ -231,10 +231,6 @@ tlc591xx_probe(struct i2c_client *client,if (!count || count > tlc591xx->max_leds)return -EINVAL ; -if (!i2c_check_functionality (client->adapter, -I2C_FUNC_SMBUS_BYTE_DATA )) -return -EIO ; - priv =devm_kzalloc (dev,sizeof (*priv),GFP_KERNEL );if (!priv)return -ENOMEM ;Signature · 1 line
2.1.0
Jacek Anaszewski
Acked-byQuoted 7 lines · Andrew Lunn
Quoted 4 lines · Axel Lin
This checking is done by
regmap_get_i2c_bus()which is called indevm_regmap_init_i2c().Signed-off-by Axel Lin <[email protected]>Reviewed-by Andrew Lunn <[email protected]>
Acked-by Jacek Anaszewski <[email protected]>
Signature · 2 lines
Best Regards, Jacek Anaszewski