Skip to contentSkip to conversation

Staging:dgap :Compression of lines for immediate return

PATCH New Shraddha Barke 1 participant 1 message Jul 27, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging:dgap :Compression of lines for immediate return

This patch compresses two lines in a single line in file dgap.c if immediate return statement is found.It also removes variable rc as it is no longer needed.

It is done using script Coccinelle.And coccinelle uses the following semantic patch for this compression function:

@@
expression ret;
identifier f;
@@

-ret =
+return

     f(...);

-return ret;

---
 drivers/staging/dgap/dgap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/dgap/dgap.c +1 -2
index b344e03..9112dd2 100644
@@ -4953,9 +4953,8 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
 		spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);
 		spin_unlock_irqrestore(&bd->bd_lock, lock_flags);
 
-		rc = put_user(C_CLOCAL(tty) ? 1 : 0,
+		return put_user(C_CLOCAL(tty) ? 1 : 0,
 				(unsigned long __user *) arg);
-		return rc;
 
 	case TIOCSSOFTCAR:
 		spin_unlock_irqrestore(&ch->ch_lock, lock_flags2);
Signature · 1 line
2.1.0