Skip to contentSkip to conversation

oeqa/qemurunner: Fix AttributeError: QemuRunner instance has no attribute 'server_socket'

PATCH New Richard Purdie 1 participant 1 message Jul 27, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 oeqa/qemurunner: Fix AttributeError: QemuRunner instance has no attribute 'server_socket'

If start() returns False due to create_socker() failing, stop() may still get called and currently this gives a track back since server_socket doesn't exist.

Avoid this.

meta/lib/oeqa/utils/qemurunner.py +1 -1
index 22bf91b..f81658f 100644
@@ -174,7 +174,7 @@ class QemuRunner:
                 logging.info("Sending SIGKILL to runqemu")
                 os.killpg(self.runqemu.pid, signal.SIGKILL)
             self.runqemu = None
-        if self.server_socket:
+        if hasattr(self, 'server_socket'):
             self.server_socket.close()
             self.server_socket = None
         self.qemupid = None