IB/mlx5: Remove dead code from alloc_cached_mr()
Subsystems (2)
PATCH 1/1 IB/mlx5: Remove dead code from alloc_cached_mr()
From: Roland Dreier <[email protected]>
The only place that assigns mr inside the loop already does a break. So "if (mr)" will never be true here since the function initializes mr to NULL at the top. We can just drop the extra if and break here.
--- drivers/infiniband/hw/mlx5/mr.c | 3 --- 1 file changed, 3 deletions(-)
drivers/infiniband/hw/mlx5/mr.c +0 -3
@@ -441,9 +441,6 @@ static struct mlx5_ib_mr *alloc_cached_mr(struct mlx5_ib_dev *dev, int order)spin_unlock_irq (&ent->lock);queue_work (cache->wq, &ent->work); - -if (mr) -break ; }if (!mr)
Signature · 6 lines
2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Eli Cohen
Acked-byQuoted 6 lines
From: Roland Dreier <[email protected]>
The only place that assigns mr inside the loop already does a break.
So "if (mr)" will never be true here since the function initializes mr to NULL at the top. We can just drop the extra if and break here.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 17 lines · Roland Dreier
From: Roland Dreier <[email protected]>
The only place that assigns mr inside the loop already does a break. So "if (mr)" will never be true here since the function initializes mr to NULL at the top. We can just drop the extra if and break here.
Signed-off-by Roland Dreier <[email protected]>--- drivers/infiniband/hw/mlx5/mr.c | 3 --- 1 file changed, 3 deletions(-)drivers/infiniband/hw/mlx5/mr.c +0
-0
drivers/infiniband/hw/mlx5/mr.c static struct mlx5_ib_mr *alloc_cached_mr(struct mlx5_ib_dev *dev, int order) · line 446
Quoted 9 lines
drivers/infiniband/hw/mlx5/mr.c +0
-3@@ -441,9 +441,6 @@ static struct mlx5_ib_mr *alloc_cached_mr(struct mlx5_ib_dev *dev, int order)spin_unlock_irq (&ent->lock);queue_work (cache->wq, &ent->work); - -if (mr) -break ; }if (!mr)
Thanks Roland. Picking this up for 4.3 today.
Signature · 2 lines
Doug Ledford <[email protected]> GPG KeyID: 0E572FDD