Skip to contentSkip to conversation

perf: Clarify the use of page::private for high-order AUX allocations

PATCH New Alexander Shishkin 2 participants 2 messages Jul 28, 2015 – Aug 12, 2015 perf events

lore
Share & tools
lore

Alexander Shishkin

author reviewer
#0 lore raw

PATCH 1/1 perf: Clarify the use of page::private for high-order AUX allocations

A question [1] was raised about the use of page::private in AUX buffer allocations, so let's add a clarification about its intended use.

The private field and flag are used by perf's rb_alloc_aux() path to tell the pmu driver the size of each high-order allocation, so that the driver can program those appropriately into its hardware. This only matters for pmus that don't support hardware scatter tables. Otherwise, every page in the buffer is just a page.

This patch adds a comment about the private field to the aux buffer allocation path.

[1] http://marc.info/?l=linux-kernel&m=143803696607968

---
 kernel/events/ring_buffer.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
kernel/events/ring_buffer.c +4 -1
index 9c01d531ee..1c892fa034 100644
@@ -472,7 +472,10 @@ static struct page *rb_alloc_aux_page(int node, int order)
 
 	if (page && order) {
 		/*
-		 * Communicate the allocation size to the driver
+		 * Communicate the allocation size to the driver:
+		 * if we managed to secure a high-order allocation,
+		 * set its first page's private to this order;
+		 * !PagePrivate(page) means it's just a normal page.
 		 */
 		split_page(page, order);
 		SetPagePrivate(page);
Signature · 1 line
2.4.6
#1 lore raw

[tip:perf/core] perf/ring-buffer: Clarify the use of page:: private for high-order AUX allocations

perf/ring-buffer: Clarify the use of page::private for high-order AUX allocations
Commit-ID:  c2ad6b51efc5f27d70ce952decd2a15679b83600
Gitweb:     http://git.kernel.org/tip/c2ad6b51efc5f27d70ce952decd2a15679b83600
Author:     Alexander Shishkin <[email protected]>
AuthorDate: Tue, 28 Jul 2015 09:00:04 +0300
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 12 Aug 2015 11:43:20 +0200

perf/ring-buffer: Clarify the use of page::private for high-order AUX allocations

A question [1] was raised about the use of page::private in AUX buffer allocations, so let's add a clarification about its intended use.

The private field and flag are used by perf's rb_alloc_aux() path to tell the pmu driver the size of each high-order allocation, so that the driver can program those appropriately into its hardware. This only matters for PMUs that don't support hardware scatter tables. Otherwise, every page in the buffer is just a page.

This patch adds a comment about the private field to the AUX buffer allocation path.

[1] http://marc.info/?l=linux-kernel&m=143803696607968

---
 kernel/events/ring_buffer.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
kernel/events/ring_buffer.c +4 -1
index c8aa3f7..182bc30 100644
@@ -437,7 +437,10 @@ static struct page *rb_alloc_aux_page(int node, int order)
 
 	if (page && order) {
 		/*
-		 * Communicate the allocation size to the driver
+		 * Communicate the allocation size to the driver:
+		 * if we managed to secure a high-order allocation,
+		 * set its first page's private to this order;
+		 * !PagePrivate(page) means it's just a normal page.
 		 */
 		split_page(page, order);
 		SetPagePrivate(page);