Skip to contentSkip to conversation

Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem

PATCH In review Jignesh R Patel 2 participants 2 messages Jul 28, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Checkpatch: driver/staging in 4.2.0-rc4: Fix coding style problem

From: Jignesh R Patel <[email protected]>

This patch fix coding style problem of more then 80 character in one line. This patch does not change any logic.

---
 drivers/staging/android/ion/ion_cma_heap.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/android/ion/ion_cma_heap.c +2 -1
index 86b91fd..4a9a7bd 100644
@@ -73,7 +73,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
 	if (!info->table)
 		goto free_mem;
 
-	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len))
+	if (dma_get_sgtable(dev, info->table, info->cpu_addr,
+						info->handle, len))
 		goto free_table;
 	/* keep this for memory release */
 	buffer->priv_virt = info;
Signature · 1 line
1.7.9.5
#1 lore raw

The subject isn't right. You aren't patch checkpatch.pl itself you're patching android.

The version doesn't go in the subject.

The subject is too vague.

Quoted 1 line · Jignesh R Patel

From: Jignesh R Patel <[email protected]>

Not needed.

Quoted 15 lines

This patch fix coding style problem of more then 80 character in one line. This patch does not change any logic.

---
 drivers/staging/android/ion/ion_cma_heap.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/android/ion/ion_cma_heap.c +0 -0
index 86b91fd..4a9a7bd 100644

drivers/staging/android/ion/ion_cma_heap.c static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer, · line 77

Quoted 6 lines
drivers/staging/android/ion/ion_cma_heap.c +2 -1
@@ -73,7 +73,8 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
 	if (!info->table)
 		goto free_mem;
 
-	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle, len))
+	if (dma_get_sgtable(dev, info->table, info->cpu_addr,
+						info->handle, len))

This isn't the right way to do it. I suppose the right thing is:

	if (dma_get_sgtable(dev, info->table, info->cpu_addr, info->handle,
			    len))

regards,
dan carpenter