Staging: rtl8188eu: fixed newlines after declarations
PATCH 4573/4573 Staging: rtl8188eu: fixed newlines after declarations
This is a patch to the rtw_debug.c file that fixes styling errors relating to new lines after variable declarations.
--- drivers/staging/rtl8188eu/core/rtw_debug.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/staging/rtl8188eu/core/rtw_debug.c +2 -0
@@ -219,6 +219,7 @@ int proc_get_ht_option(char *page, char **start,struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);int len =0 ; + len +=snprintf (page + len, count - len,"ht_option=%d\n" , pmlmepriv->htpriv.ht_option); *eof =1 ;return len;
@@ -588,6 +589,7 @@ int proc_set_rx_signal(struct file *file, const char __user *buffer,if (buffer && !copy_from_user (tmp, buffer,sizeof (tmp))) {int num =sscanf (tmp,"%u %u" , &is_signal_dbg, &signal_strength); + is_signal_dbg = is_signal_dbg ==0 ?0 :1 ;if (is_signal_dbg && num !=2 )return count;
Signature · 1 line
2.4.5
Greg KH
maintainerQuoted 6 lines · Dave Perez
This is a patch to the
rtw_debug.cfile that fixes styling errors relating to new lines after variable declarations.Signed-off-by Dave Perez <[email protected]>--- drivers/staging/rtl8188eu/core/rtw_debug.c | 2 ++ 1 file changed, 2 insertions(+)
Where are the 4572 other patches in this series?
:)
Can you please line-wrap your commit message, and fix up the patch numbering and resend?
thanks,
greg k-h
Quoted 1 line · Dave Perez
This is a patch to the
rtw_debug.cfile that fixes styling errors relating to new lines after variable declarations.
[]
drivers/staging/rtl8188eu/core/rtw_debug.c
Quoted 1 line
drivers/staging/rtl8188eu/core/rtw_debug.c +0
-0
[]
drivers/staging/rtl8188eu/core/rtw_debug.c int proc_get_ht_option(char *page, char **start, · line 225
Quoted 8 lines
drivers/staging/rtl8188eu/core/rtw_debug.c +1
-0@@ -219,6 +219,7 @@ int proc_get_ht_option(char *page, char **start,struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);int len =0 ; + len +=snprintf (page + len, count - len,"ht_option=%d\n" , pmlmepriv->htpriv.ht_option); *eof =1 ;return len;
the blank line before "int len = 0" could also be removed.
The routine _could_ be rewritten more simply as:
struct mlme_priv *pmlmepriv = &padapter->mlmepriv; int len = snprintf(page, count, "ht_option=%d\n", pmlmepriv->htpriv.htoption); *eof = 1; return len; }
but there are a bunch of other routines that use this form so it's probably fine as-is.