Skip to contentSkip to conversation

Patch "usb: dwc3: gadget: return error if command sent to DEPCMD register fails" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Jul 30, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: dwc3: gadget: return error if command sent to DEPCMD register fails

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-dwc3-gadget-return-error-if-command-sent-to-depcmd-register-fails.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 76e838c9f7765f9a6205b4d558d75a66104bc60d Mon Sep 17 00:00:00 2001

From: Subbaraya Sundeep Bhatta <[email protected]>
Date: Thu, 21 May 2015 15:46:48 +0530
Subject: usb: dwc3: gadget: return error if command sent to DEPCMD register fails

From: Subbaraya Sundeep Bhatta <[email protected]>

commit 76e838c9f7765f9a6205b4d558d75a66104bc60d upstream.

We need to return error to caller if command is not sent to controller succesfully.

Fixes 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
---
 drivers/usb/dwc3/gadget.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/usb/dwc3/gadget.c +2 -0
@@ -337,6 +337,8 @@ int dwc3_send_gadget_ep_cmd(struct dwc3
 		if (!(reg & DWC3_DEPCMD_CMDACT)) {
 			dev_vdbg(dwc->dev, "Command Complete --> %d\n",
 					DWC3_DEPCMD_STATUS(reg));
+			if (DWC3_DEPCMD_STATUS(reg))
+				return -EINVAL;
 			return 0;
 		}
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/usb-dwc3-reset-the-transfer-resource-index-on-set_interface.patch queue-3.14/usb-dwc3-gadget-return-error-if-command-sent-to-depcmd-register-fails.patch queue-3.14/usb-dwc3-gadget-return-error-if-command-sent-to-dgcmd-register-fails.patch