Skip to contentSkip to conversation

Patch "SUNRPC: Fix a memory leak in the backchannel code" has been added to the 3.10-stable tree

PATCH [email protected] 1 participant 1 message Jul 31, 2015

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

SUNRPC: Fix a memory leak in the backchannel code

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
sunrpc-fix-a-memory-leak-in-the-backchannel-code.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 88de6af24f2b48b06c514d3c3d0a8f22fafe30bd Mon Sep 17 00:00:00 2001

From: Trond Myklebust <[email protected]>
Date: Mon, 1 Jun 2015 15:10:25 -0400
Subject: SUNRPC: Fix a memory leak in the backchannel code

From: Trond Myklebust <[email protected]>

commit 88de6af24f2b48b06c514d3c3d0a8f22fafe30bd upstream.

req->rq_private_buf isn't initialised when xprt_setup_backchannel calls xprt_free_allocation.

Fixes fb7a0b9addbdb ("nfs41: New backchannel helper routines")
---
 net/sunrpc/backchannel_rqst.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/sunrpc/backchannel_rqst.c +1 -1
@@ -60,7 +60,7 @@ static void xprt_free_allocation(struct
 
 	dprintk("RPC:        free allocations for req= %p\n", req);
 	WARN_ON_ONCE(test_bit(RPC_BC_PA_IN_USE, &req->rq_bc_pa_state));
-	xbufp = &req->rq_private_buf;
+	xbufp = &req->rq_rcv_buf;
 	free_page((unsigned long)xbufp->head[0].iov_base);
 	xbufp = &req->rq_snd_buf;
 	free_page((unsigned long)xbufp->head[0].iov_base);

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/nfs-increase-size-of-exchange_id-name-string-buffer.patch queue-3.10/fixing-infinite-open-loop-in-4.0-stateid-recovery.patch queue-3.10/sunrpc-fix-a-memory-leak-in-the-backchannel-code.patch queue-3.10/nfs-fix-size-of-nfsacl-setacl-operations.patch